Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useTextSelection): keep the selected text range when secondary button of mouse is pressed #2232

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

Ali-ovo
Copy link
Contributor

@Ali-ovo Ali-ovo commented Jun 25, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #2223

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese 当鼠标右键点击的时候不清空state

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@Ali-ovo Ali-ovo force-pushed the fix-useTextSelection branch from 60b6069 to 4bb1cc8 Compare June 25, 2023 03:46
@liuyib liuyib self-requested a review June 25, 2023 07:54
@liuyib liuyib changed the title fix(bug): useTextSelection bug fix(useTextSelection): keep the selected text range when secondary button of mouse is pressed Jun 27, 2023
@crazylxr crazylxr merged commit 3efc83b into alibaba:master Jul 5, 2023
askwuxue pushed a commit to askwuxue/hooks that referenced this pull request Jul 29, 2023
…tton of mouse is pressed (alibaba#2232)

* fix(bug): useTextSelection bug

* test: add case for the secondary button of mouse

---------

Co-authored-by: liuyib <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useTextSelection 选中文本后,鼠标右键后选中的内容发生了变化
3 participants