-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: useKeyPress callback passes in the triggered shortcut key #2170
Conversation
几个问题:
@yunsii 这样是不是满足你的需求并且用法较为方便了? @hchlq @miracles1919 @li-jia-nan @crazylxr 看下这样的思路可以吗? |
做了下调整,现在code是匹配keyFilter中的值传入了 |
有空了看哈 |
@liuyib 是这个意思,根据用户输入返回,很完美 |
+1 ,感觉没啥问题 |
LGTM |
…aba#2170) * feat: useKeyPress callback passes in the triggered shortcut key * chore: update md * chore: update * fix: test * chore: update md * chore: update md * chore: update * style: change name to pascal * docs: fix type in eventHandler * style: rename 'code' to 'key' * chore: add new demo * test: rename & remove useless option * refactor: 当 keyFilter 传函数时保持原来的用法 * fix: can't pass ci when keyFilter is array * fix: second callback is not be called * chore: firedKey when functional keyFilter * chore: update * test: better case * test: update * test: remove useless * refactor: keyFilter 传函数的情况,不用再处理 exactMatch --------- Co-authored-by: liuyib <[email protected]>
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close: #1404
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge