-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(createUseStorageState): adjust type of defaultValue
and update docs
#2148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuyib
commented
Apr 7, 2023
liuyib
commented
Apr 7, 2023
liuyib
commented
Apr 7, 2023
liuyib
commented
Apr 7, 2023
@li-jia-nan @hchlq @miracles1919 first CR, please ❤️ |
liuyib
commented
Apr 7, 2023
li-jia-nan
reviewed
Apr 8, 2023
li-jia-nan
reviewed
Apr 8, 2023
有冲突了 |
好的,稍后解决下 |
defaultValue
and update docs
|
18 tasks
crazylxr
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
none
💡 Background and solution
Background:
In the old code, the type of
defaultValue
isT | IFuncUpdater<T>
,IFuncUpdater
is as follow:This means that if
defaultValue
is a function, it can accept apreviousState
parameter, but actually, it makes no sense to do so, and there is no parameter was passed todefaultValue
in real code.So,
defaultValue
type just should be:By the way, this PR also do some other changes, as follow:
remove useless
/* eslint-disable */
remove useless type definition
simplify code:
from:
to:
📝 Changelog
☑️ Self Check before Merge