Skip to content

Commit

Permalink
fix: usePagination/useAntdTable/useFusionTable params ts error
Browse files Browse the repository at this point in the history
  • Loading branch information
brickspert committed Dec 16, 2021
1 parent 28f9912 commit 136c79f
Show file tree
Hide file tree
Showing 6 changed files with 28 additions and 17 deletions.
19 changes: 15 additions & 4 deletions packages/hooks/src/useAntdTable/index.tsx
Original file line number Diff line number Diff line change
@@ -1,8 +1,15 @@
import { useEffect, useRef, useState } from 'react';
import { useMemoizedFn, usePagination, useUpdateEffect } from '..';
import type { Antd4ValidateFields, AntdTableOptions, Data, Params, Service } from './types';

const useAntdTable = <TData extends Data, TParams extends any[] = Params>(
import type {
Antd4ValidateFields,
AntdTableOptions,
Data,
Params,
Service,
AntdTableResult,
} from './types';

const useAntdTable = <TData extends Data, TParams extends Params>(
service: Service<TData, TParams>,
options: AntdTableOptions<TData, TParams> = {},
) => {
Expand Down Expand Up @@ -119,6 +126,7 @@ const useAntdTable = <TData extends Data, TParams extends any[] = Params>(
current: 1,
};
if (!form) {
// @ts-ignore
run(pagination);
return;
}
Expand All @@ -129,6 +137,7 @@ const useAntdTable = <TData extends Data, TParams extends any[] = Params>(
...values,
};

// @ts-ignore
run(pagination, values, {
allFormData: allFormDataRef.current,
type,
Expand All @@ -152,6 +161,7 @@ const useAntdTable = <TData extends Data, TParams extends any[] = Params>(

const onTableChange = (pagination: any, filters: any, sorter: any) => {
const [oldPaginationParams, ...restParams] = params || [];
// @ts-ignore
run(
{
...oldPaginationParams,
Expand All @@ -170,6 +180,7 @@ const useAntdTable = <TData extends Data, TParams extends any[] = Params>(
if (params.length > 0) {
allFormDataRef.current = cacheFormTableData?.allFormData || {};
restoreForm();
// @ts-ignore
run(...params);
return;
}
Expand Down Expand Up @@ -232,7 +243,7 @@ const useAntdTable = <TData extends Data, TParams extends any[] = Params>(
changeType: useMemoizedFn(changeType),
reset: useMemoizedFn(reset),
},
};
} as AntdTableResult<TData, TParams>;
};

export default useAntdTable;
6 changes: 3 additions & 3 deletions packages/hooks/src/useAntdTable/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export type Params = [
...any[]
];

export type Service<TData extends Data, TParams extends any[]> = (
export type Service<TData extends Data, TParams extends Params> = (
...args: TParams
) => Promise<TData>;

Expand All @@ -33,7 +33,7 @@ export interface AntdFormUtils {
[key: string]: any;
}

export interface AntdTableResult<TData extends Data, TParams extends any[]>
export interface AntdTableResult<TData extends Data, TParams extends Params>
extends PaginationResult<TData, TParams> {
tableProps: {
dataSource: any[];
Expand All @@ -50,7 +50,7 @@ export interface AntdTableResult<TData extends Data, TParams extends any[]>
};
}

export interface AntdTableOptions<TData extends Data, TParams extends any[]>
export interface AntdTableOptions<TData extends Data, TParams extends Params>
extends PaginationOptions<TData, TParams> {
form?: AntdFormUtils;
defaultType?: 'simple' | 'advance';
Expand Down
2 changes: 1 addition & 1 deletion packages/hooks/src/useFusionTable/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import type { Data, Params, Service } from '../useAntdTable/types';
import { fieldAdapter, resultAdapter } from './fusionAdapter';
import type { FusionTableOptions, FusionTableResult } from './types';

const useFusionTable = <TData extends Data, TParams extends any[] = Params>(
const useFusionTable = <TData extends Data, TParams extends Params>(
service: Service<TData, TParams>,
options: FusionTableOptions<TData, TParams> = {},
): FusionTableResult<TData, TParams> => {
Expand Down
6 changes: 3 additions & 3 deletions packages/hooks/src/useFusionTable/types.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { AntdTableOptions, AntdTableResult, Data } from '../useAntdTable/types';
import type { AntdTableOptions, AntdTableResult, Data, Params } from '../useAntdTable/types';

export interface Field {
getFieldInstance?: (name: string) => {};
Expand All @@ -9,7 +9,7 @@ export interface Field {
[key: string]: any;
}

export interface FusionTableResult<TData extends Data, TParams extends any[]>
export interface FusionTableResult<TData extends Data, TParams extends Params>
extends Omit<AntdTableResult<TData, TParams>, 'tableProps'> {
paginationProps: {
onChange: (current: number) => void;
Expand All @@ -32,7 +32,7 @@ export interface FusionTableResult<TData extends Data, TParams extends any[]>
};
}

export interface FusionTableOptions<TData extends Data, TParams extends any[]>
export interface FusionTableOptions<TData extends Data, TParams extends Params>
extends Omit<AntdTableOptions<TData, TParams>, 'form'> {
field?: Field;
}
6 changes: 3 additions & 3 deletions packages/hooks/src/usePagination/index.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { useMemo } from 'react';
import { useMemoizedFn, useRequest } from '..';
import type { Data, PaginationOptions, Params, Service } from './types';
import type { Data, PaginationOptions, Params, Service, PaginationResult } from './types';

const usePagination = <TData extends Data, TParams extends any[] = Params>(
const usePagination = <TData extends Data, TParams extends Params>(
service: Service<TData, TParams>,
options: PaginationOptions<TData, TParams> = {},
) => {
Expand Down Expand Up @@ -61,7 +61,7 @@ const usePagination = <TData extends Data, TParams extends any[] = Params>(
changeCurrent: useMemoizedFn(changeCurrent),
changePageSize: useMemoizedFn(changePageSize),
},
};
} as PaginationResult<TData, TParams>;
};

export default usePagination;
6 changes: 3 additions & 3 deletions packages/hooks/src/usePagination/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@ export type Data = { total: number; list: any[] };

export type Params = [{ current: number; pageSize: number; [key: string]: any }, ...any[]];

export type Service<TData extends Data, TParams extends any[]> = (
export type Service<TData extends Data, TParams extends Params> = (
...args: TParams
) => Promise<TData>;

export interface PaginationResult<TData extends Data, TParams extends any[]>
export interface PaginationResult<TData extends Data, TParams extends Params>
extends Result<TData, TParams> {
pagination: {
current: number;
Expand All @@ -21,7 +21,7 @@ export interface PaginationResult<TData extends Data, TParams extends any[]>
};
}

export interface PaginationOptions<TData extends Data, TParams extends any[]>
export interface PaginationOptions<TData extends Data, TParams extends Params>
extends Options<TData, TParams> {
defaultPageSize?: number;
}

0 comments on commit 136c79f

Please sign in to comment.