Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): improve formily scope standard specification #3212

Merged
merged 4 commits into from
Jun 20, 2022

Conversation

janryWang
Copy link
Collaborator

@janryWang janryWang commented Jun 19, 2022

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

#3207

@codecov
Copy link

codecov bot commented Jun 19, 2022

Codecov Report

Merging #3212 (6331dee) into formily_next (6eed89b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@               Coverage Diff                @@
##           formily_next    #3212      +/-   ##
================================================
+ Coverage         96.12%   96.14%   +0.01%     
================================================
  Files               149      152       +3     
  Lines              6553     6586      +33     
  Branches           1770     1777       +7     
================================================
+ Hits               6299     6332      +33     
  Misses              254      254              
Impacted Files Coverage Δ
packages/react/src/components/RecordScope.tsx 100.00% <100.00%> (ø)
packages/react/src/components/RecordsScope.tsx 100.00% <100.00%> (ø)
packages/react/src/components/RecursionField.tsx 100.00% <100.00%> (ø)
packages/react/src/components/SchemaField.tsx 100.00% <100.00%> (ø)
packages/react/src/components/index.ts 100.00% <100.00%> (ø)
packages/react/src/hooks/index.ts 100.00% <100.00%> (ø)
packages/react/src/hooks/useExpressionScope.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eed89b...6331dee. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 19, 2022

Size Change: +775 B (0%)

Total Size: 508 kB

Filename Size Change
packages/antd/dist/formily.antd.umd.development.js 71.5 kB +175 B (0%)
packages/antd/dist/formily.antd.umd.production.js 39.9 kB +125 B (0%)
packages/next/dist/formily.next.umd.development.js 76.4 kB +57 B (0%)
packages/next/dist/formily.next.umd.production.js 44.3 kB +61 B (0%)
packages/react/dist/formily.react.umd.development.js 11.7 kB +208 B (+2%)
packages/react/dist/formily.react.umd.production.js 7.27 kB +149 B (+2%)
ℹ️ View Unchanged
Filename Size
packages/core/dist/formily.core.umd.development.js 20 kB
packages/core/dist/formily.core.umd.production.js 13.4 kB
packages/element/dist/formily.element.umd.development.js 63.1 kB
packages/element/dist/formily.element.umd.production.js 36.6 kB
packages/grid/dist/formily.grid.umd.development.js 9.01 kB
packages/grid/dist/formily.grid.umd.production.js 6.07 kB
packages/json-schema/dist/formily.json-schema.umd.development.js 6.96 kB
packages/json-schema/dist/formily.json-schema.umd.production.js 4.43 kB
packages/path/dist/formily.path.umd.development.js 11.2 kB
packages/path/dist/formily.path.umd.production.js 7.72 kB
packages/reactive-react/dist/formily.reactive-react.umd.development.js 3.61 kB
packages/reactive-react/dist/formily.reactive-react.umd.production.js 2.25 kB
packages/reactive-vue/dist/formily.reactive-vue.umd.development.js 2.96 kB
packages/reactive-vue/dist/formily.reactive-vue.umd.production.js 1.87 kB
packages/reactive/dist/formily.reactive.umd.development.js 9.45 kB
packages/reactive/dist/formily.reactive.umd.production.js 5.27 kB
packages/shared/dist/formily.shared.umd.development.js 7.42 kB
packages/shared/dist/formily.shared.umd.production.js 4.3 kB
packages/validator/dist/formily.validator.umd.development.js 8.43 kB
packages/validator/dist/formily.validator.umd.production.js 6.28 kB
packages/vue/dist/formily.vue.umd.development.js 16.5 kB
packages/vue/dist/formily.vue.umd.production.js 9.85 kB

compressed-size-action

@janryWang janryWang merged commit 0811c87 into formily_next Jun 20, 2022
@janryWang janryWang deleted the improve_formily_scope_standard_specification branch June 20, 2022 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant