Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix set initialValue no cache value when display none #3182

Merged
merged 1 commit into from
Jun 12, 2022

Conversation

janryWang
Copy link
Collaborator

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

Fixed #3163

@codecov
Copy link

codecov bot commented Jun 12, 2022

Codecov Report

Merging #3182 (8fa295f) into formily_next (d705f56) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##           formily_next    #3182   +/-   ##
=============================================
  Coverage         96.12%   96.12%           
=============================================
  Files               149      149           
  Lines              6547     6553    +6     
  Branches           1826     1828    +2     
=============================================
+ Hits               6293     6299    +6     
  Misses              225      225           
  Partials             29       29           
Impacted Files Coverage Δ
packages/core/src/shared/internals.ts 100.00% <100.00%> (ø)
packages/react/src/components/ReactiveField.tsx 93.33% <0.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d705f56...8fa295f. Read the comment docs.

@github-actions
Copy link
Contributor

Size Change: +22 B (0%)

Total Size: 507 kB

Filename Size Change
packages/core/dist/formily.core.umd.development.js 20 kB +12 B (0%)
packages/core/dist/formily.core.umd.production.js 13.4 kB +10 B (0%)
ℹ️ View Unchanged
Filename Size
packages/antd/dist/formily.antd.umd.development.js 71.3 kB
packages/antd/dist/formily.antd.umd.production.js 39.8 kB
packages/element/dist/formily.element.umd.development.js 63.1 kB
packages/element/dist/formily.element.umd.production.js 36.6 kB
packages/grid/dist/formily.grid.umd.development.js 9.01 kB
packages/grid/dist/formily.grid.umd.production.js 6.07 kB
packages/json-schema/dist/formily.json-schema.umd.development.js 6.96 kB
packages/json-schema/dist/formily.json-schema.umd.production.js 4.43 kB
packages/next/dist/formily.next.umd.development.js 76.3 kB
packages/next/dist/formily.next.umd.production.js 44.2 kB
packages/path/dist/formily.path.umd.development.js 11.2 kB
packages/path/dist/formily.path.umd.production.js 7.72 kB
packages/react/dist/formily.react.umd.development.js 11.4 kB
packages/react/dist/formily.react.umd.production.js 7.12 kB
packages/reactive-react/dist/formily.reactive-react.umd.development.js 3.61 kB
packages/reactive-react/dist/formily.reactive-react.umd.production.js 2.25 kB
packages/reactive-vue/dist/formily.reactive-vue.umd.development.js 2.96 kB
packages/reactive-vue/dist/formily.reactive-vue.umd.production.js 1.87 kB
packages/reactive/dist/formily.reactive.umd.development.js 9.45 kB
packages/reactive/dist/formily.reactive.umd.production.js 5.27 kB
packages/shared/dist/formily.shared.umd.development.js 7.42 kB
packages/shared/dist/formily.shared.umd.production.js 4.3 kB
packages/validator/dist/formily.validator.umd.development.js 8.43 kB
packages/validator/dist/formily.validator.umd.production.js 6.28 kB
packages/vue/dist/formily.vue.umd.development.js 16.5 kB
packages/vue/dist/formily.vue.umd.production.js 9.85 kB

compressed-size-action

@janryWang janryWang merged commit 66ffeb6 into formily_next Jun 12, 2022
@janryWang janryWang deleted the fix_set_initialValue_no_cache_value branch June 12, 2022 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] setInitialValues设置不上初始值
1 participant