Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(antd/next): fix props.prefix is not work for FormGrid/FormLayout #2151

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

janryWang
Copy link
Collaborator

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

Fixed #2124

@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #2151 (9de2572) into formily_next (48f574e) will increase coverage by 2.53%.
The diff coverage is 99.73%.

Impacted file tree graph

@@               Coverage Diff                @@
##           formily_next    #2151      +/-   ##
================================================
+ Coverage         92.70%   95.24%   +2.53%     
================================================
  Files               136      138       +2     
  Lines              6114     6183      +69     
  Branches           1520     1562      +42     
================================================
+ Hits               5668     5889     +221     
+ Misses              442      289     -153     
- Partials              4        5       +1     
Impacted Files Coverage Δ
packages/core/src/shared/internals.ts 99.64% <99.53%> (+3.85%) ⬆️
packages/core/src/effects/onFieldEffects.ts 97.18% <100.00%> (+0.57%) ⬆️
packages/core/src/effects/onFormEffects.ts 100.00% <100.00%> (ø)
packages/core/src/models/ArrayField.ts 100.00% <100.00%> (ø)
packages/core/src/models/Field.ts 99.10% <100.00%> (-0.12%) ⬇️
packages/core/src/models/Form.ts 100.00% <100.00%> (+0.30%) ⬆️
packages/core/src/models/Heart.ts 100.00% <100.00%> (ø)
packages/core/src/models/ObjectField.ts 100.00% <100.00%> (ø)
packages/core/src/models/VoidField.ts 100.00% <100.00%> (ø)
packages/core/src/shared/constants.ts 100.00% <100.00%> (ø)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e684bb7...9de2572. Read the comment docs.

@github-actions
Copy link
Contributor

Size Change: +30 B (0%)

Total Size: 2.46 MB

Filename Size Change
designable/antd/dist/formily.designable.antd.umd.production.js 282 kB +1 B (0%)
designable/next/dist/formily.designable.next.umd.development.js 412 kB +9 B (0%)
designable/next/dist/formily.designable.next.umd.production.js 289 kB +3 B (0%)
designable/setters/dist/formily.designable.antd.umd.development.js 373 kB +2 B (0%)
designable/setters/dist/formily.designable.antd.umd.production.js 262 kB +4 B (0%)
packages/antd/dist/formily.antd.umd.development.js 61.4 kB +3 B (0%)
packages/next/dist/formily.next.umd.development.js 62.9 kB +6 B (0%)
packages/next/dist/formily.next.umd.production.js 36.6 kB +2 B (0%)
ℹ️ View Unchanged
Filename Size
designable/antd/dist/formily.designable.antd.umd.development.js 400 kB
packages/antd/dist/formily.antd.umd.production.js 34.9 kB
packages/core/dist/formily.core.umd.development.js 19.6 kB
packages/core/dist/formily.core.umd.production.js 13 kB
packages/element/dist/formily.element.umd.development.js 55.1 kB
packages/element/dist/formily.element.umd.production.js 31.5 kB
packages/json-schema/dist/formily.json-schema.umd.development.js 6.73 kB
packages/json-schema/dist/formily.json-schema.umd.production.js 4.19 kB
packages/path/dist/formily.path.umd.development.js 13.2 kB
packages/path/dist/formily.path.umd.production.js 8.45 kB
packages/react/dist/formily.react.umd.development.js 11.1 kB
packages/react/dist/formily.react.umd.production.js 6.83 kB
packages/reactive-react/dist/formily.reactive-react.umd.development.js 3.61 kB
packages/reactive-react/dist/formily.reactive-react.umd.production.js 2.26 kB
packages/reactive-vue/dist/formily.reactive-vue.umd.development.js 2.83 kB
packages/reactive-vue/dist/formily.reactive-vue.umd.production.js 1.8 kB
packages/reactive/dist/formily.reactive.umd.development.js 8.74 kB
packages/reactive/dist/formily.reactive.umd.production.js 5.01 kB
packages/shared/dist/formily.shared.umd.development.js 7.38 kB
packages/shared/dist/formily.shared.umd.production.js 4.19 kB
packages/validator/dist/formily.validator.umd.development.js 8.24 kB
packages/validator/dist/formily.validator.umd.production.js 6.15 kB
packages/vue/dist/formily.vue.umd.development.js 14.6 kB
packages/vue/dist/formily.vue.umd.production.js 9.16 kB

compressed-size-action

@janryWang janryWang merged commit bcdac58 into formily_next Sep 14, 2021
@janryWang janryWang deleted the fix_props_prefix branch September 14, 2021 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] @alifd/next form-layout form-grid 支持props传入自定义 prefix
1 participant