coro/Generator: correct Generator alias of std::generator #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before this change, the build fails, because `AlloAllocator` is not defined when the standard library provides `std::generator`, and the tree is built with C++23. in this change, we replace `AlloAllocator` with `Allocator`. and the tree builds fine. Signed-off-by: Kefu Chai <[email protected]>
std::generator is a feature provided by C++23, when the tree is built
with C++20, even if `<generator>` header is available, we still don't
have access to `std::generator`. and the compiler would fail to compile:
```
In file included from /home/kefu/dev/async_simple/async_simple/coro/test/GeneratorTest.cpp:29:
/home/kefu/dev/async_simple/async_simple/coro/Generator.h:32:24: error: no template named 'generator' in namespace 'std'; did you mean 'generate'?
32 | using Generator = std::generator<Ref, V, Allocator>;
| ~~~~~^~~~~~~~~
| generate
/usr/lib/gcc/x86_64-redhat-linux/14/../../../../include/c++/14/bits/stl_algo.h:4344:5: note: 'generate' declared here
4344 | generate(_ForwardIterator __first, _ForwardIterator __last,
| ^
In file included from /home/kefu/dev/async_simple/async_simple/coro/test/GeneratorTest.cpp:29:
/home/kefu/dev/async_simple/async_simple/coro/Generator.h:32:19: error: expected a type
32 | using Generator = std::generator<Ref, V, Allocator>;
| ^
/home/kefu/dev/async_simple/async_simple/coro/Generator.h:32:24: error: expected ';' after alias declaration
32 | using Generator = std::generator<Ref, V, Allocator>;
| ^
| ;
```
in this change, we guard the include with `__cpp_lib_generator`,
to address the FTBFS.
Signed-off-by: Kefu Chai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before this change, the build fails, because
AlloAllocatoris not defined when the standard library providesstd::generator, and the tree is built with C++23.in this change, we replace
AlloAllocatorwithAllocator. and the tree builds fine.also, we include
<generator>only if__cpp_lib_generatoris defined. as the existence of the header does not imply that we are building with C++23.