-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix some typos and add basic nginx authentication doc #226
base: master
Are you sure you want to change the base?
fix some typos and add basic nginx authentication doc #226
Conversation
Codecov Report
@@ Coverage Diff @@
## master #226 +/- ##
=========================================
- Coverage 4.86% 4.61% -0.26%
=========================================
Files 221 190 -31
Lines 10950 9347 -1603
Branches 1939 1620 -319
=========================================
- Hits 533 431 -102
+ Misses 10366 8873 -1493
+ Partials 51 43 -8
Continue to review full report at Codecov.
|
f768448
to
023f33f
Compare
Hi, sorry for the late reply. I just finished my busy work for the Double eleven shopping festival. I am planning to back to the Arthas community. I'd like to continue on reviewing the existing pull request within days, please ping me if there is no progress. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good
|
#15
After typing correct account, you can then enter:
Chrome might cached the account, so you can test it with incognito window