Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some typos and add basic nginx authentication doc #226

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Hearen
Copy link
Contributor

@Hearen Hearen commented Oct 12, 2018

#15

image

After typing correct account, you can then enter:

image

Chrome might cached the account, so you can test it with incognito window

@codecov-io
Copy link

codecov-io commented Oct 12, 2018

Codecov Report

Merging #226 into master will decrease coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #226      +/-   ##
=========================================
- Coverage    4.86%   4.61%   -0.26%     
=========================================
  Files         221     190      -31     
  Lines       10950    9347    -1603     
  Branches     1939    1620     -319     
=========================================
- Hits          533     431     -102     
+ Misses      10366    8873    -1493     
+ Partials       51      43       -8
Impacted Files Coverage Δ
...thas/core/command/klass100/ClassLoaderCommand.java 0% <0%> (ø) ⬆️
...o/arthas/core/command/monitor200/TraceCommand.java 0% <0%> (ø) ⬆️
...n/java/com/taobao/arthas/core/util/ThreadUtil.java 0% <0%> (ø) ⬆️
...ao/arthas/core/command/express/ExpressFactory.java 0% <0%> (ø) ⬆️
.../taobao/arthas/core/shell/cli/CompletionUtils.java 0% <0%> (ø) ⬆️
.../java/com/taobao/arthas/core/util/SearchUtils.java 0% <0%> (ø) ⬆️
...aobao/arthas/core/command/klass100/JadCommand.java 0% <0%> (ø) ⬆️
...rthas/core/command/monitor200/TimeTunnelTable.java 0% <0%> (ø) ⬆️
.../java/com/taobao/arthas/core/advisor/Enhancer.java 0% <0%> (ø) ⬆️
...arthas/core/command/klass100/DumpClassCommand.java 0% <0%> (ø) ⬆️
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b45b3a...023f33f. Read the comment docs.

@Hearen Hearen force-pushed the adding-basic-authentication-web-console branch from f768448 to 023f33f Compare October 13, 2018 01:42
@ralf0131
Copy link
Collaborator

Hi, sorry for the late reply.

I just finished my busy work for the Double eleven shopping festival. I am planning to back to the Arthas community. I'd like to continue on reviewing the existing pull request within days, please ping me if there is no progress.

Copy link

@geektcp geektcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants