-
Notifications
You must be signed in to change notification settings - Fork 29
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(tags): write an annotated git tag (#989)
Some other tools like `git describe` (used by lerna) will only return annotated tags. As well, the git documentation ([link](https://git-scm.com/book/en/v2/Git-Basics-Tagging)) primarily documents writing annotated tags. This commit changes the behaviour of tags written by shipjs to write annotated tags
- Loading branch information
Showing
2 changed files
with
6 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,7 @@ describe('createGitTag', () => { | |
}); | ||
expect(run).toHaveBeenCalledTimes(1); | ||
expect(run).toHaveBeenCalledWith({ | ||
command: 'git tag v1.2.3', | ||
command: 'git tag -a v1.2.3 -m v1.2.3', | ||
dir: '.', | ||
dryRun: false, | ||
}); | ||
|
@@ -27,7 +27,8 @@ describe('createGitTag', () => { | |
}); | ||
expect(run).toHaveBeenCalledTimes(1); | ||
expect(run).toHaveBeenCalledWith({ | ||
command: 'git tag [email protected] && git tag swag@4', | ||
command: | ||
'git tag -a [email protected] -m [email protected] && git tag -a swag@4 -m swag@4', | ||
dir: '.', | ||
dryRun: false, | ||
}); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters