fix: remove releaseStart hook for slack message (#703)

Co-authored-by: shipjs <[email protected]>
algolia · Mar 6, 2020 · 2a9502b · 2a9502b
1 parent de9083c
commit 2a9502b
Show file tree

Hide file tree

Showing 7 changed files with 95 additions and 194 deletions.
diff --git a/packages/shipjs-lib/src/lib/config/__tests__/mergeConfig.spec.js b/packages/shipjs-lib/src/lib/config/__tests__/mergeConfig.spec.js
@@ -44,7 +44,6 @@ describe('mergeConfig', () => {
             username: 'Ship.js',
           },
           prepared: () => {},
-          releaseStart: () => {},
           releaseSuccess: () => {},
         },
       },
@@ -58,7 +57,6 @@ describe('mergeConfig', () => {
     );
     expect(config.slack.default.username).toEqual('Release');
     expect(config.slack.prepared).toBeInstanceOf(Function);
-    expect(config.slack.releaseStart).toBeInstanceOf(Function);
     expect(config.slack.releaseSuccess).toBeInstanceOf(Function);
   });
 
@@ -70,19 +68,17 @@ describe('mergeConfig', () => {
             username: 'Ship.js',
           },
           prepared: () => {},
-          releaseStart: () => {},
           releaseSuccess: () => {},
         },
       },
       {
         slack: {
-          releaseStart: null,
+          releaseSuccess: null,
         },
       }
     );
     expect(config.slack.default.username).toEqual('Ship.js');
     expect(config.slack.prepared).toBeInstanceOf(Function);
-    expect(config.slack.releaseStart).toBeNull();
-    expect(config.slack.releaseSuccess).toBeInstanceOf(Function);
+    expect(config.slack.releaseSuccess).toBeNull();
   });
 });
diff --git a/packages/shipjs-lib/src/lib/config/defaultConfig.js b/packages/shipjs-lib/src/lib/config/defaultConfig.js
@@ -140,31 +140,6 @@ export default {
         },
       ],
     }),
-    releaseStart: ({
-      appName,
-      version,
-      latestCommitHash,
-      latestCommitUrl,
-    }) => ({
-      pretext: `:rocket: Starting to release *${appName}@${version}*`,
-      fields: [
-        {
-          title: 'Branch',
-          value: 'master',
-          short: true,
-        },
-        {
-          title: 'Commit',
-          value: `*<${latestCommitUrl}|${latestCommitHash}>*`,
-          short: true,
-        },
-        {
-          title: 'Version',
-          value: version,
-          short: true,
-        },
-      ],
-    }),
     releaseSuccess: ({
       appName,
       version,

diff --git a/packages/shipjs/src/flow/release.js b/packages/shipjs/src/flow/release.js
@@ -4,7 +4,6 @@ import printHelp from '../step/release/printHelp';
 import printDryRunBanner from '../step/printDryRunBanner';
 import validate from '../step/release/validate';
 import gatherRepoInfo from '../step/release/gatherRepoInfo';
-import notifyReleaseStart from '../step/release/notifyReleaseStart';
 import runTest from '../step/release/runTest';
 import runBuild from '../step/release/runBuild';
 import runBeforePublish from '../step/release/runBeforePublish';
@@ -37,13 +36,6 @@ async function release({ help = false, dir = '.', dryRun = false }) {
     repoURL,
     releaseTag,
   } = gatherRepoInfo({ remote, version, dir });
-  await notifyReleaseStart({
-    config,
-    appName,
-    version,
-    latestCommitHash,
-    latestCommitUrl,
-  });
   const isYarn = detectYarn(dir);
   runTest({ isYarn, config, dir, dryRun });
   runBuild({ isYarn, config, version, dir, dryRun });

diff --git a/packages/shipjs/src/step/release/notifyReleaseStart.js b/packages/shipjs/src/step/release/notifyReleaseStart.js
diff --git a/packages/shipjs/src/util/index.js b/packages/shipjs/src/util/index.js
@@ -3,11 +3,7 @@ export { default as exitProcess } from './exitProcess';
 export { default as indentedPrint } from './indentedPrint';
 export { default as print } from './print';
 export { default as run } from './run';
-export {
-  notifyPrepared,
-  notifyReleaseStart,
-  notifyReleaseSuccess,
-} from './slack';
+export { notifyPrepared, notifyReleaseSuccess } from './slack';
 export { default as wrapExecWithDir } from './wrapExecWithDir';
 export { default as wrapRun } from './wrapRun';
 export { default as parseArgs } from './parseArgs';
diff --git a/packages/shipjs/src/util/slack.js b/packages/shipjs/src/util/slack.js
@@ -37,30 +37,6 @@ export async function notifyPrepared({
   });
 }
 
-export async function notifyReleaseStart({
-  config,
-  appName,
-  version,
-  latestCommitHash,
-  latestCommitUrl,
-}) {
-  const { slack = {} } = config;
-  const { releaseStart } = slack;
-  if (!releaseStart) {
-    return;
-  }
-
-  const sendArguments =
-    typeof releaseStart === 'function'
-      ? releaseStart({ appName, version, latestCommitHash, latestCommitUrl })
-      : releaseStart;
-
-  await sendSlackMessage({
-    config,
-    sendArguments,
-  });
-}
-
 export async function notifyReleaseSuccess({
   config,
   appName,