feat(voice): allow custom voice helper #4363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the `createVoiceHelper` function can be overridden, other third-party voice solutions can be used, without them needing to redo all the rendering & templating. cc @dylanbfox
Haroenv
commented
Apr 7, 2020
|
Thanks @dustincoates, @eunjae-lee & @francoischalifour, this is now ready for review again |
eunjae-lee
approved these changes
May 5, 2020
|
@francoischalifour would you mind giving this a review? :) |
francoischalifour
approved these changes
May 11, 2020
|
@Haroenv Do we plan to roll this out in all flavors at once or in IS.js first? |
|
InstantSearch.js was enough for now, but will add other flavours soon I guess :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If the
createVoiceHelperfunction can be overridden, other third-party voice solutions can be used, without them needing to redo all the rendering & templating.Result
Allow custom
createVoiceHelperto be passed to the widget & connector.cc @dylanbfox
todo: