chore(stories): add categories #4154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
eunjae-lee and
tkrugg
and removed request for
a team
samouss
reviewed
Oct 1, 2019
|
@samouss Do you have an easy solution in mind? Storybook's documentation isn't clear about sorting categories of stories. |
|
already upvoted this once apparently but: storybookjs/storybook#548 (comment) |
|
there's also storybookjs/storybook#548 (comment) |
|
Typing issues on Storybook's end... Let's wait for storybookjs/storybook#8233 to be fixed. |
Haroenv
reviewed
Oct 1, 2019
|
we can add |
francoischalifour
force-pushed
the
chore/stories-categories
branch
from
bb36e27 to
b75e537
Compare
|
Upgrading to Storybook 5.2.3 fixed the issue. |
Haroenv
reviewed
Oct 7, 2019
|
@Haroenv PR sent in algolia/doc#3807. I'm also updating the PR for the new |
Haroenv
approved these changes
Oct 7, 2019
|
The order of the sections changed in the doc in the meantime ahah. I'll reflect the order in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds sections in our Storybook following the same organization as the documentation API ref.
Note that this updates the stories URLs and therefore we need to update the documentation links for v4.
Let me know if you want to go that route so that I PR the doc repo.
Preview
See stories →