Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Reindex SKU Form #1098

Merged
merged 2 commits into from
Feb 15, 2019
Merged

Update Reindex SKU Form #1098

merged 2 commits into from
Feb 15, 2019

Conversation

bsuravech
Copy link
Contributor

@bsuravech bsuravech commented Jan 16, 2019 •
edited by jira bot
Loading

Summary
[[MAG-68]](https://algolia.atlassian.net/browse/MAG-68) Improve Reindex SKU form to show detailed name and qualifications for try/catch/continue

Result

  • Improved try/catches to allow some storeviews to continue when one of them doesn't qualify
  • Updated store name to show from which website/store group/store view
  • Updated global attributes to not include store since it is not neccessary.

@0livier 0livier requested a review from damcou January 18, 2019 16:08
@bsuravech bsuravech requested review from JanPetr and damcou and removed request for damcou January 18, 2019 16:08
JanPetr
JanPetr approved these changes Feb 14, 2019
View reviewed changes
Copy link
Contributor

@JanPetr JanPetr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

damcou
damcou approved these changes Feb 14, 2019
View reviewed changes
Copy link
Contributor

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bsuravech bsuravech merged commit 66ae296 into develop Feb 15, 2019
@bsuravech bsuravech deleted the update-reindex-sku branch February 15, 2019 16:32
@bsuravech bsuravech mentioned this pull request Apr 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanPetr JanPetr JanPetr approved these changes

@damcou damcou damcou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bsuravech @JanPetr @damcou