Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ts): correct type for listIndices response #1236

Merged
merged 1 commit into from
Dec 3, 2020

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Dec 3, 2020

  1. the type for createdAt & updatedAt is actually a string timestamp, not a number
  2. the type should be called Index, not Indice
  3. add the types for replica-related properties

see https://www.algolia.com/doc/api-reference/api-methods/list-indices/ for the reference

@Haroenv Haroenv merged commit 0bb6bba into master Dec 3, 2020
@Haroenv Haroenv deleted the fix/list-indices-type branch December 3, 2020 09:45
@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 3, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ddcde0c:

Sandbox Source
javascript-client-app Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants