fix(findAnswers): expose in lite version #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't do this for bundlesize, but I guess it makes sense. You still need to update the size :) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 83906d7:
|
It didn't exceed the current threshold :) |
|
can you add the integration test on browser-lite now too? it's https://github.com/algolia/algoliasearch-client-javascript/blob/master/specs/answers.spec.ts (you can see https://github.com/algolia/algoliasearch-client-javascript/blob/master/specs/search.spec.ts for lite usage) |
This was referenced Mar 10, 2021
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR exposes
findAnswersmethod in the lite version. In our documents, we kind of encourage to usealgoliasearch/litea lot. So we'd better have this method in the lite version as well for better adoption.