Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable impl_trait_in_assoc_type feature #23

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Conversation

jnalanko
Copy link
Contributor

The build is currently broken on latest nightly because the feature impl_trait_in_assoc_type has been put behind a feature gate. I am getting errors like:

error[E0658]: `impl Trait` in associated types is unstable
  --> crates/hashes/src/cn_nthash.rs:63:25
   |
63 |       type IteratorType = impl Iterator<
   |  _________________________^
64 | |         Item = <CanonicalNtHashIteratorFactory as HashFunctionFactory>...
65 | |     >;
   | |_____^
   |
   = note: see issue #63063 <https://github.com/rust-lang/rust/issues/63063> for more information
   = help: add `#![feature(impl_trait_in_assoc_type)]` to the crate attributes to enable

This commit fixes these errors.

Copy link

@rchikhi rchikhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, had the same issue and implemented the same fix. It compiles fine with v1.70.0-nightly, the problem occurs with >= v1.71.0-nighly

@Guilucand Guilucand merged commit 96e72bb into algbio:main Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants