Various fixes #15
Merged
Various fixes #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Handle the `fram` error message in a way that mitigates a firmware bug * CLI: resync on open * upgrade base64 * update the firmware parsing regex
alfred-hodler
force-pushed
the
fram_fixi_cli_resync_fix
branch
from
e14c3eb to
635c96d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle the
framerror message in a way that mitigates a firmware bug:FramingErrorbeing raised by the firmware does not set theis_lastflag correctly, causing our end of the wire to hang. This addresses that problem.CLI: correctly resync on open.
upgrade dependencies (
aes-ctrwas deprecated)update the firmware parsing regex