Update Providers_model.php #1529
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To handle deprecation on lines 527 and 529
|
Hello! Thanks for this PR. I see the problem but it looks like this one requires some additional handling. I will take a closer look.
|
alextselegidis
added a commit
that referenced
this pull request
May 21, 2024
|
Added check for this case
|
tm8544
added a commit
to tm8544/easyappointments
that referenced
this pull request
May 21, 2024
Add empty value check (alextselegidis#1529)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To handle deprecations on lines 527 and 529.
strtotime(): Passing null to parameter #1 ($datetime) of type string is deprecatedWhen there is a full-day exception,
$working_plan_exception['start']and$working_plan_exception['end']are bothnullThis is an issue that came up on #1497 and at some point it seemed to be cleared, so I closed #1497.
Now it is back, and now I can explain more precisely the conditions it occurs.
First of all it is not an exception but a deprecation, but if handled now there would be no exceptions later on with future php versions.
This appears under the following conditions:
config.phpthere isconst DEBUG_MODE = true;anderror_reportinginphp.inihas been set to report deprecations.Maybe this is the reason you did not see this. In my case both conditions were met.