Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Deprecation warning on Ruby 3.4 #565

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ndemianc
Copy link
Contributor

Fixes #558

The temporarily fix was added 2 years ago at 3eb5ce2 at ruby-openai version 3.2.0.
The Upgrading guide from that time was also removed from README.md as well, so I believe it is already save to remove the compatibility fix.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?

@ndemianc
Copy link
Contributor Author

@alexrudall please review, when You have time.

@alexrudall
Copy link
Owner

Will do, I want to include it in v8 along with #566. Thanks for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation warning on Ruby 3.4
2 participants