Skip to content

Commit

Permalink
Merge branch 'master' of https://github.com/argoproj/argo-cd into bug…
Browse files Browse the repository at this point in the history
…s/rate-limit-failed-logins
  • Loading branch information
jannfis committed Apr 16, 2020
2 parents 68e490a + 75d9f23 commit e94869a
Show file tree
Hide file tree
Showing 80 changed files with 2,781 additions and 684 deletions.
45 changes: 45 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,12 @@ commands:
root: .
paths:
- coverage.out
save_node_modules:
steps:
- persist_to_workspace:
root: ~/argo-cd
paths:
- ui/node_modules
attach_vendor:
steps:
- attach_workspace:
Expand Down Expand Up @@ -156,6 +162,35 @@ jobs:
path: test-results
destination: .

lint:
working_directory: /go/src/github.com/argoproj/argo-cd
docker:
- image: argoproj/argocd-test-tools:v0.2.0
steps:
- prepare_environment
- checkout
- configure_git
- restore_vendor
- run: dep ensure -v
- restore_go_cache_docker
- run:
name: Run golangci-lint
command: ARGOCD_LINT_GOGC=10 make lint-local
- run:
name: Check that nothing has changed
command: |
gDiff=$(git diff)
if test "$gDiff" != ""; then
echo
echo "###############################################################################"
echo "golangci-lint has made automatic corrections to your code. Please check below"
echo "diff output and commit this to your local branch, or run make lint locally."
echo "###############################################################################"
echo
git diff
exit 1
fi
sonarcloud:
working_directory: /go/src/github.com/argoproj/argo-cd
docker:
Expand Down Expand Up @@ -191,11 +226,16 @@ jobs:
chmod +x $SCANNER_DIRECTORY/sonar-scanner-$VERSION-$OS/bin/sonar-scanner
chmod +x $SCANNER_DIRECTORY/sonar-scanner-$VERSION-$OS/jre/bin/java
# Workaround for a possible bug in CircleCI
if ! echo $CIRCLE_PULL_REQUEST | grep https://github.com/argoproj; then
unset CIRCLE_PULL_REQUEST
unset CIRCLE_PULL_REQUESTS
fi
# Explicitly set NODE_MODULES
export NODE_MODULES=/go/src/github.com/argoproj/argo-cd/ui/node_modules
export NODE_PATH=/go/src/github.com/argoproj/argo-cd/ui/node_modules
$SCANNER_DIRECTORY/sonar-scanner-$VERSION-$OS/bin/sonar-scanner
name: SonarCloud
- save_cache:
Expand Down Expand Up @@ -296,6 +336,7 @@ jobs:
- run: ./node_modules/.bin/codecov -p ..
- run: NODE_ENV='production' yarn build
- run: yarn lint
- save_node_modules

orbs:
sonarcloud: sonarsource/[email protected]
Expand All @@ -314,10 +355,14 @@ workflows:
- ui:
requires:
- build
- lint:
requires:
- build
- sonarcloud:
context: SonarCloud
requires:
- test
- ui
- e2e:
requires:
- build
27 changes: 27 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,32 @@
# Changelog

## v1.5.2 (2020-04-20)

#### Critical security fix

This release contains a critical security fix. Please refer to the
[security document](https://argoproj.github.io/argo-cd/security_considerations/#CVE-2020-5260-possible-git-credential-leak)
for more information.

**Upgrading is strongly recommended**

## v1.4.3 (2020-04-20)

#### Critical security fix

This release contains a critical security fix. Please refer to the
[security document](https://argoproj.github.io/argo-cd/security_considerations/#CVE-2020-5260-possible-git-credential-leak)
for more information.

## v1.5.1 (2020-04-06)

#### Bug Fixes

* fix: return 401 error code if username does not exist (#3369)
* fix: Do not panic while running hooks with short revision (#3368)
* fix: Increase HAProxy check interval to prevent intermittent failures (#3356)
* fix: Helm v3 CRD are not deployed (#3345)

## v1.5.0 (2020-04-02)

#### Helm Integration Enhancements - Helm 3 Support And More
Expand Down
10 changes: 7 additions & 3 deletions Gopkg.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ ARGOCD_E2E_YARN_HOST?=localhost
ARGOCD_IN_CI?=false
ARGOCD_TEST_E2E?=true

ARGOCD_LINT_GOGC?=100

# Runs any command in the argocd-test-utils container in server mode
# Server mode container will start with uid 0 and drop privileges during runtime
define run-in-test-server
Expand Down Expand Up @@ -70,6 +72,7 @@ define run-in-test-client
-e GOPATH=/go \
-e ARGOCD_E2E_K3S=$(ARGOCD_E2E_K3S) \
-e GOCACHE=/tmp/go-build-cache \
-e ARGOCD_LINT_GOGC=$(ARGOCD_LINT_GOGC) \
-v ${DOCKER_SRCDIR}:/go/src${VOLUME_MOUNT} \
-v ${GOCACHE}:/tmp/go-build-cache${VOLUME_MOUNT} \
-v ${HOME}/.kube:/home/user/.kube${VOLUME_MOUNT} \
Expand Down Expand Up @@ -279,7 +282,7 @@ lint-local:
golangci-lint --version
# NOTE: If you get a "Killed" OOM message, try reducing the value of GOGC
# See https://github.com/golangci/golangci-lint#memory-usage-of-golangci-lint
GOGC=100 golangci-lint run --fix --verbose
GOGC=$(ARGOCD_LINT_GOGC) GOMAXPROCS=2 golangci-lint run --fix --verbose --timeout 300s

.PHONY: lint-ui
lint-ui:
Expand Down
55 changes: 39 additions & 16 deletions assets/swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@
"ApplicationService"
],
"summary": "List returns list of applications",
"operationId": "List",
"operationId": "ListMixin8",
"parameters": [
{
"type": "string",
Expand Down Expand Up @@ -237,7 +237,7 @@
"ApplicationService"
],
"summary": "Create creates an application",
"operationId": "Create",
"operationId": "CreateMixin8",
"parameters": [
{
"name": "body",
Expand All @@ -264,7 +264,7 @@
"ApplicationService"
],
"summary": "Update updates an application",
"operationId": "Update",
"operationId": "UpdateMixin8",
"parameters": [
{
"type": "string",
Expand Down Expand Up @@ -395,7 +395,7 @@
"ApplicationService"
],
"summary": "Get returns an application by name",
"operationId": "Get",
"operationId": "GetMixin8",
"parameters": [
{
"type": "string",
Expand Down Expand Up @@ -445,7 +445,7 @@
"ApplicationService"
],
"summary": "Delete deletes an application",
"operationId": "Delete",
"operationId": "DeleteMixin8",
"parameters": [
{
"type": "string",
Expand Down Expand Up @@ -1084,7 +1084,7 @@
"ClusterService"
],
"summary": "List returns list of clusters",
"operationId": "ListMixin4",
"operationId": "List",
"parameters": [
{
"type": "string",
Expand All @@ -1106,7 +1106,7 @@
"ClusterService"
],
"summary": "Create creates a cluster",
"operationId": "CreateMixin4",
"operationId": "Create",
"parameters": [
{
"name": "body",
Expand All @@ -1133,7 +1133,7 @@
"ClusterService"
],
"summary": "Update updates a cluster",
"operationId": "UpdateMixin4",
"operationId": "Update",
"parameters": [
{
"type": "string",
Expand Down Expand Up @@ -1166,7 +1166,7 @@
"ClusterService"
],
"summary": "Get returns a cluster by server address",
"operationId": "GetMixin4",
"operationId": "GetMixin2",
"parameters": [
{
"type": "string",
Expand All @@ -1189,7 +1189,7 @@
"ClusterService"
],
"summary": "Delete deletes a cluster",
"operationId": "DeleteMixin4",
"operationId": "Delete",
"parameters": [
{
"type": "string",
Expand Down Expand Up @@ -1239,7 +1239,7 @@
"ProjectService"
],
"summary": "List returns list of projects",
"operationId": "ListMixin5",
"operationId": "ListMixin6",
"parameters": [
{
"type": "string",
Expand All @@ -1261,7 +1261,7 @@
"ProjectService"
],
"summary": "Create a new project.",
"operationId": "CreateMixin5",
"operationId": "CreateMixin6",
"parameters": [
{
"name": "body",
Expand All @@ -1288,7 +1288,7 @@
"ProjectService"
],
"summary": "Get returns a project by name",
"operationId": "GetMixin5",
"operationId": "GetMixin6",
"parameters": [
{
"type": "string",
Expand All @@ -1311,7 +1311,7 @@
"ProjectService"
],
"summary": "Delete deletes a project",
"operationId": "DeleteMixin5",
"operationId": "DeleteMixin6",
"parameters": [
{
"type": "string",
Expand Down Expand Up @@ -1386,7 +1386,7 @@
"ProjectService"
],
"summary": "Update updates a project",
"operationId": "UpdateMixin5",
"operationId": "UpdateMixin6",
"parameters": [
{
"type": "string",
Expand Down Expand Up @@ -1905,7 +1905,7 @@
"SettingsService"
],
"summary": "Get returns Argo CD settings",
"operationId": "GetMixin7",
"operationId": "Get",
"responses": {
"200": {
"description": "(empty)",
Expand Down Expand Up @@ -2038,6 +2038,9 @@
"format": "int64",
"title": "expiresIn represents a duration in seconds"
},
"id": {
"type": "string"
},
"name": {
"type": "string"
}
Expand Down Expand Up @@ -2357,6 +2360,12 @@
"kustomizeOptions": {
"$ref": "#/definitions/v1alpha1KustomizeOptions"
},
"kustomizeVersions": {
"type": "array",
"items": {
"type": "string"
}
},
"oidcConfig": {
"$ref": "#/definitions/clusterOIDCConfig"
},
Expand Down Expand Up @@ -2431,6 +2440,9 @@
"format": "int64",
"title": "expiresIn represents a duration in seconds"
},
"id": {
"type": "string"
},
"project": {
"type": "string"
},
Expand Down Expand Up @@ -3415,6 +3427,10 @@
"nameSuffix": {
"type": "string",
"title": "NameSuffix is a suffix appended to resources for kustomize apps"
},
"version": {
"type": "string",
"title": "Version contains optional Kustomize version"
}
}
},
Expand Down Expand Up @@ -3789,6 +3805,9 @@
"iat": {
"type": "string",
"format": "int64"
},
"id": {
"type": "string"
}
}
},
Expand Down Expand Up @@ -3839,6 +3858,10 @@
"type": "object",
"title": "KustomizeOptions are options for kustomize to use when building manifests",
"properties": {
"binaryPath": {
"type": "string",
"title": "BinaryPath holds optional path to kustomize binary"
},
"buildOptions": {
"type": "string",
"title": "BuildOptions is a string of build parameters to use when calling `kustomize build`"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package main
package commands

import (
"fmt"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package main
package commands

import (
"testing"
Expand Down
Loading

0 comments on commit e94869a

Please sign in to comment.