Skip to content
This repository has been archived by the owner on Mar 8, 2022. It is now read-only.

Add support for connect mfa options #313

Closed
wants to merge 3 commits into from

Conversation

woz5999
Copy link
Contributor

@woz5999 woz5999 commented Jan 11, 2021

Proposed Changes

  • Support connection mfa options

Fixes #310

Acceptance Test Output

$ make testacc TESTS=TestAccConnection
==> Checking that code complies with gofmt requirements...
?       github.com/alexkappa/terraform-provider-auth0   [no test files]
=== RUN   TestAccConnection
--- PASS: TestAccConnection (6.12s)
=== RUN   TestAccConnectionAD
--- PASS: TestAccConnectionAD (2.36s)
=== RUN   TestAccConnectionAzureAD
--- PASS: TestAccConnectionAzureAD (3.13s)
=== RUN   TestAccConnectionOIDC
--- PASS: TestAccConnectionOIDC (4.93s)
=== RUN   TestAccConnectionOAuth2
--- PASS: TestAccConnectionOAuth2 (3.76s)
=== RUN   TestAccConnectionWithEnbledClients
--- PASS: TestAccConnectionWithEnbledClients (15.09s)
=== RUN   TestAccConnectionSMS
--- PASS: TestAccConnectionSMS (2.01s)
=== RUN   TestAccConnectionEmail
--- PASS: TestAccConnectionEmail (4.02s)
=== RUN   TestAccConnectionSalesforce
--- PASS: TestAccConnectionSalesforce (2.35s)
=== RUN   TestAccConnectionGoogleOAuth2
--- PASS: TestAccConnectionGoogleOAuth2 (1.96s)
=== RUN   TestAccConnectionFacebook
--- PASS: TestAccConnectionFacebook (4.15s)
=== RUN   TestAccConnectionApple
--- PASS: TestAccConnectionApple (3.56s)
=== RUN   TestAccConnectionLinkedin
--- PASS: TestAccConnectionLinkedin (3.66s)
=== RUN   TestAccConnectionGitHub
--- PASS: TestAccConnectionGitHub (8.46s)
=== RUN   TestAccConnectionConfiguration
--- PASS: TestAccConnectionConfiguration (4.51s)
=== RUN   TestAccConnectionSAML
    TestAccConnectionSAML: testing.go:705: Step 0 error: errors during apply:
        
        Error: 400 Bad Request: The signing certificate is not valid. Please provide a .pem or .cer certificate base64 encoded public key
        
          on /var/folders/ny/xc92y7xs1szbdr9skq_s7b4h0000gq/T/tf-test771952802/main.tf line 2:
          (source code not available)
        
        
--- FAIL: TestAccConnectionSAML (0.46s)
FAIL
coverage: 26.1% of statements
FAIL    github.com/alexkappa/terraform-provider-auth0/auth0     70.813s
?       github.com/alexkappa/terraform-provider-auth0/auth0/internal/debug      [no test files]
testing: warning: no tests to run
PASS
coverage: 0.0% of statements
ok      github.com/alexkappa/terraform-provider-auth0/auth0/internal/random     0.272s  coverage: 0.0% of statements [no tests to run]
testing: warning: no tests to run
PASS
coverage: 0.0% of statements
ok      github.com/alexkappa/terraform-provider-auth0/auth0/internal/validation 0.297s  coverage: 0.0% of statements [no tests to run]
?       github.com/alexkappa/terraform-provider-auth0/version   [no test files]
FAIL
make: *** [testacc] Error 1

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

@woz5999
Copy link
Contributor Author

woz5999 commented Jan 11, 2021

Note that the failed saml test is unrelated to these code changes and appears to be caused by some test dependencies not present in my environment

@woz5999
Copy link
Contributor Author

woz5999 commented Jan 11, 2021

I'm not sure the cause of the check failure, but it seems unrelated to the code change? Possible build system or transient network issue.

Copy link
Owner

@alexkappa alexkappa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @woz5999, thanks for putting this together! I see the new fields are defined in the schema but I can't find any expand or flatten operations with it.

We might need to add it here and here

The certificate errors should go away if you rebase your changes on top of the latest master.

@woz5999
Copy link
Contributor Author

woz5999 commented Jan 25, 2021

@alexkappa changes pushed. not sure the best way to test. Re-ran the acceptance tests and they passed, but they passed the first time too.

Also rebased and looks like the label check is still failing =[ looks like it's complaining about a repo-token now

@alexkappa
Copy link
Owner

@woz5999, awesome! I've merged the changes and will push a release soon. (Not sure why the PR is not marked as merged)

@alexkappa alexkappa closed this Jan 26, 2021
@woz5999
Copy link
Contributor Author

woz5999 commented Jan 26, 2021

@alexkappa are you sure this was merged? i don't see the changes in master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for MFA options in connection resource
2 participants