Skip to content
This repository has been archived by the owner on Mar 8, 2022. It is now read-only.

Add additional optional user profile attributes #166

Merged
merged 1 commit into from
Feb 3, 2020

Conversation

garry-jeromson
Copy link
Contributor

Adds the optional user profile attributes name, family_name, given_name, blocked and picture, which may be useful to set during user resource creation/modification.

Available user profile attributes are detailed here: https://auth0.com/docs/users/references/user-profile-structure#user-profile-attributes

Copy link
Owner

@alexkappa alexkappa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @garry-jeromson, thanks for helping with the project. The user related resources seem good, there's tests and all so its good to merge.

There are however other changes that may be unnecessary, making this PR harder to merge. Could you elaborate why there were changes needed to the tenant tests? The role examples are okay, I guess, but also unnecessary right? The new fields are optional?

Finally the readme is re-formatted entirely, making a whole bunch of changes that don't need to be made.

@garry-jeromson
Copy link
Contributor Author

Howdy @alexkappa , thanks for taking a look.

I'll revert the readme formatting changes, format-on-save was the culprit there. (Line length preferences are each to their own.)

Will revert the role examples, too; showing optional atrributes in the user example is good enough.

As for the tenant acceptance tests, they currently fail (at least with the tenant I tested with) because the values for the timeouts are above the maximum. Do they pass for you on the current master branch?

@alexkappa
Copy link
Owner

Perfect, thanks @garry-jeromson.

As for the tenant acceptance tests, they currently fail (at least with the tenant I tested with) because the values for the timeouts are above the maximum. Do they pass for you on the current master branch?

Yes, they pass normally and for a while now... Perhaps something to do with your tenant? Or maybe in combination with tenant flags enabled on your tenant.

@garry-jeromson
Copy link
Contributor Author

garry-jeromson commented Jan 31, 2020

Interesting - definitely sounds like it's tenant-specific, or perhaps something to do with free vs. paid subscriptions. In any case, as long as the tests pass on master, all good, so will remove the unnecessary commit.

Thanks for the quick feedback!

Adds the optional user profile attributes `name`, `family_name`, `given_name`, `blocked` and `picture`, which may be useful to set during user resource creation/modification.
@alexkappa alexkappa merged commit ff60640 into alexkappa:master Feb 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants