Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URI encoding for payment URL and QR codes are incorrect #5

Closed
takinbo opened this issue Jul 1, 2018 · 1 comment
Closed

URI encoding for payment URL and QR codes are incorrect #5

takinbo opened this issue Jul 1, 2018 · 1 comment

Comments

@takinbo
Copy link
Contributor

takinbo commented Jul 1, 2018

The URI encoding for the payment url and QR code are incorrect. Rather than concatenating using the ? character, the & character should be used instead. I was able to determine this when my wallet couldn't decode the QR code and I'll be submitting a pull request shortly.
alexk111 added a commit that referenced this issue Jul 2, 2018
@alexk111
Merge pull request #6 from takinbo/master
8b53d5d 
fixes #5 by properly encoding the bitcoin URI
@alexk111
Copy link
Owner

alexk111 commented Jul 2, 2018

Thank you @takinbo 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@takinbo @alexk111