errorMissedIgnores parameter #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heya, thanks for the PR. Your code makes it a warning instead of an error to fail a build, which is fine, but I suppose I wouldn't call it "ignore". Additionally, please update the README where appropriate. Thanks |
pzi
requested changes
Jul 1, 2024
pzi
reviewed
Jul 25, 2024
pzi
reviewed
Jul 25, 2024
Co-authored-by: Patrik Affentranger <[email protected]>
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
pzi
reviewed
Aug 2, 2024
There was a problem hiding this comment.
LGTM, thanks @josh-linushealth
ps: Idk what's going on, github keeps telling me i need to review this :(. I will just ignore it from now on...
|
thanks for taking care of this Patrik. Sorry for the lack of response!
…On Fri, 2 Aug 2024 at 17:05, Patrik Affentranger ***@***.***> wrote:
***@***.**** commented on this pull request.
LGTM, thanks @josh-linushealth <https://github.com/josh-linushealth>
—
Reply to this email directly, view it on GitHub
<#48 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC4U5KKIPOS3AJGHQ6DB4LZPNDWLAVCNFSM6AAAAABJ2MPGP2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMJVGA4DSMRWGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces parameter to only raise a warning when CVE's defined in the ignore list are not found in scan results. Currently this will result in an error.
This parameter defaults to true as to remain a non-impactful change.