emit error event instead of throw error

[fengmk2]

I think just emit error event is better than throw it on ConnectionManager.prototype.onSocketData().

When network come wrong, the zk response data will fault. And node-zookeeper-client throw error when data format incorrect, it will let node process exit.

I think use error event is better. If use care about error, he will listen the error event and reconnect zk server again.

@see alibaba/node-hbase-client#22

[alexguan]

Right now, zookeeper client does not emit error event directly to the user since just throwing out errors does no good for the user.

The correct way to handle those errors are actually described in the comments. The client should disconnect and reconnect again when this kind of error happens.

Have you encountered those errors during usage?

[fengmk2]

@alexguan I meet the error on my test environment. The test environment network will interrupt random, to mock network instability condition. So I can test my hbase client on the test environment and find out the potential bugs.

Because zookeeper client is async, I can't try catch the throw errors.

If zk client emit the error, I can listen the error event, and log it, then let zk client disconnect and reconnect again.

[fengmk2]

If user not listen the error event, node process will just throw it.

@see http://nodejs.org/docs/latest/api/events.html#events_class_events_eventemitter

When an EventEmitter instance experiences an error, the typical action is to emit an 'error' event. Error events are treated as a special case in node. If there is no listener for it, then the default action is to print a stack trace and exit the program.

[alexguan]

I understand the problem, however, I do think there is a better way to handle it than emitting error. I'm thinking of disconnecting and reconnecting automatically when those scenarios happen.

[fengmk2]

I see. I'm waiting for your implementation. I want to use zk client on my production environment as soon as posible.

[alexguan]

working on it now, will post an update soon

[fengmk2]

Cool!
在 2013-5-24 AM9:33，"Alex Guan" [email protected]写道：

working on it now, will post an update soon

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/5#issuecomment-18382012
.

[fengmk2]

Any progress?

[alexguan]

Got stuck with work, will address this soon, hopefully before the weekend.