Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: async upgrade #122

Merged
merged 2 commits into from
Jun 15, 2022
Merged

fix: async upgrade #122

merged 2 commits into from
Jun 15, 2022

Conversation

rramk
Copy link
Contributor

@rramk rramk commented Jun 8, 2022

No description provided.

@rramk
Copy link
Contributor Author

rramk commented Jun 8, 2022

@alexguan Please take a look. This will fix the upgrade issue in 1.1.2 as mentioned in this issue

@rramk
Copy link
Contributor Author

rramk commented Jun 10, 2022

Hi @alexguan, could you please look into this. It's a bit urgent

@alexguan
Copy link
Owner

I'm quite busy this week, most likely this will be pushed to next week. If this is a fundamental issue as described in #121, we should get more bug reports, right?

@rramk
Copy link
Contributor Author

rramk commented Jun 10, 2022

No idea why anyone else didn't raise the issue but I can see it too. Basically, nothing works because async had a breaking change which I didn't heed (my bad)
@alexguan

@wuteng606
Copy link

I also encountered the same problem. I hope can merge the code as soon as possible.

@JamesYYang
Copy link

same problem +1

@luckyyyyy
Copy link

same problem +2

@luckyyyyy
Copy link

@alexguan I hope can merge the code as soon as possible and publish, this issue is urgent

@jmaicher
Copy link

Can confirm, we're also affected by this.

@alexguan
Copy link
Owner

@rramk Can you update the CHANGELOG file mentioned the fix as well? After that I can merge and publish today.

@alexguan alexguan merged commit eec7a56 into alexguan:master Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants