Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F1155 channels 43437, 43439, 40015, 40016 added #1

Merged
merged 4 commits into from
Jan 2, 2019
Merged

F1155 channels 43437, 43439, 40015, 40016 added #1

merged 4 commits into from
Jan 2, 2019

Conversation

yozik04
Copy link

@yozik04 yozik04 commented Dec 30, 2018

Added a must have channels for F1155.

HM-pump speed, Brine Pump Speed, Brine in temperature, Brine out temperature.

@alexf2015
Copy link
Owner

Thanks for your contribution. Please

  1. remove 43437, it has already been moved to the base channels and thus is available for all models
  2. please check if channel 44270 ( Calculated Cooling Supply Temperature S1 ) is also available for model F1155. It has recently been added for F1145 so I guess it is also available for F1155.

Thanks
Alex

@alexf2015 alexf2015 self-assigned this Dec 31, 2018
@yozik04
Copy link
Author

yozik04 commented Dec 31, 2018

I do not have cooling available in my model. As Iunderstood it requires some additional modules to make it available.

Copy link
Owner

@alexf2015 alexf2015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok then please just remove "f1155-type-43437"

@yozik04
Copy link
Author

yozik04 commented Jan 2, 2019

Done.

@yozik04
Copy link
Author

yozik04 commented Jan 2, 2019

Wait a second. Something wrong is here. Where should this channel go. To compressor or generic?

@yozik04
Copy link
Author

yozik04 commented Jan 2, 2019

Now it is right and working.

@yozik04
Copy link
Author

yozik04 commented Jan 2, 2019

For F1255 base-type-47041 "Hot water mode" has also option 4 (smart control).
I do not know if other systems have it.

Should I add it?

@alexf2015 alexf2015 merged commit caf63db into alexf2015:nibeuplink-dev Jan 2, 2019
alexf2015 pushed a commit that referenced this pull request Jan 2, 2019
alexf2015 pushed a commit that referenced this pull request Feb 18, 2019
alexf2015 pushed a commit that referenced this pull request Feb 21, 2019
alexf2015 pushed a commit that referenced this pull request Feb 23, 2019
alexf2015 pushed a commit that referenced this pull request Feb 23, 2019
alexf2015 pushed a commit that referenced this pull request Feb 25, 2023
…penhab#13695)

* [jsscripting] Refactor ThreadsafeTimers to create futures inline instead of in an extra methods
* [jsscripting] Introduce utility class for providing easy access to script services
* [jsscripting] Reimplement timer creation methods from ScriptExecution for thread-safety
* [jsscripting] Add missing JavaDoc for reimplement timer creation methods
* [jsscripting] Remove the future from the map when setTimeout expires
* [jsscripting] Rename `GraalJSScriptServiceUtil` to `JSScriptServiceUtil`
* [jsscripting] Remove the `createTimerWithArgument` method
* [jsscripting] Replace the OSGi workaround of `JSScriptServiceUtil` with an injection mechanism
* [jsscripting] Use constructor to inject `JSScriptServiceUtil` into `GraalJSScriptEngineFactory`
* [jsscripting] Minor improvements by @J-N-K (#1)
* [jsscripting] Minor changes related to last commit to keep flexibility of `JSRuntimeFeatures`
* [jsscripting] Upgrade openhab-js to v2.1.1
* [jsscripting] Remove unused code

Signed-off-by: Florian Hotze <[email protected]>
Co-authored-by: Jan N. Klug <[email protected]>
alexf2015 pushed a commit that referenced this pull request Jan 3, 2025
* Fixes in indexes from Ruepert #1

Signed-off-by: Konstantin Polihronov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants