Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move tctl to temporal #1153

Merged
merged 1 commit into from
Mar 1, 2025
Merged

Conversation

rgee0
Copy link
Contributor

@rgee0 rgee0 commented Mar 1, 2025

Description

Temporal appear to have moved their cli from being tctl to a cli named temporal. This was causing the e2e url checker to fail in the pipeline.

This change updates the tctl entry to become temporal

Motivation and Context

  • I have raised an issue to propose this change, which has been given a label of design/approved by a maintainer (required)

How Has This Been Tested?

Functional

➜  arkade git:(updatetctl) make build 
go build
➜  arkade git:(updatetctl) ✗ ./arkade get temporal
Downloading: temporal
2025/03/01 07:27:29 Looking up version for: temporal
2025/03/01 07:27:29 Found: v1.3.0
Downloading: https://github.com/temporalio/cli/releases/download/v1.3.0/temporal_cli_1.3.0_darwin_arm64.tar.gz
29.56 MiB / 29.56 MiB [--------------------------------------------------------------------------------] 100.00%
/var/folders/22/3b_f27kj3s37lbfqz_fq44jw0000gp/T/arkade-1661334802/temporal_cli_1.3.0_darwin_arm64.tar.gz written.
2025/03/01 07:27:31 Extracted: /var/folders/22/3b_f27kj3s37lbfqz_fq44jw0000gp/T/arkade-1661334802/temporal
2025/03/01 07:27:31 Copying /var/folders/22/3b_f27kj3s37lbfqz_fq44jw0000gp/T/arkade-1661334802/temporal to /Users/rgee0/.arkade/bin/temporal

Wrote: /Users/rgee0/.arkade/bin/temporal (104.3MB)

# Add arkade binary directory to your PATH variable
export PATH=$PATH:$HOME/.arkade/bin/

# Test the binary:
/Users/rgee0/.arkade/bin/temporal

# Or install with:
sudo mv /Users/rgee0/.arkade/bin/temporal /usr/local/bin/

👏 Say thanks for arkade and sponsor Alex via GitHub: https://github.com/sponsors/alexellis

./hack/test-tool.sh

➜  arkade git:(updatetctl) ✗ ./hack/test-tool.sh temporal
+ ./arkade get temporal --arch arm64 --os darwin --quiet
+ file /Users/rgee0/.arkade/bin/temporal
/Users/rgee0/.arkade/bin/temporal: Mach-O 64-bit executable arm64
+ rm /Users/rgee0/.arkade/bin/temporal
+ echo

+ ./arkade get temporal --arch x86_64 --os darwin --quiet
+ file /Users/rgee0/.arkade/bin/temporal
/Users/rgee0/.arkade/bin/temporal: Mach-O 64-bit executable x86_64
+ rm /Users/rgee0/.arkade/bin/temporal
+ echo

+ ./arkade get temporal --arch x86_64 --os linux --quiet
+ file /Users/rgee0/.arkade/bin/temporal
/Users/rgee0/.arkade/bin/temporal: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, Go BuildID=N0fuFf-gJ9MupXYQUvef/tx49Dg51S_WfGKNtP8pK/4cadYmUT6eBWVa3ED0MZ/N8iln9ZdvPDNu1TY5X4q, stripped
+ rm /Users/rgee0/.arkade/bin/temporal
+ echo

+ ./arkade get temporal --arch aarch64 --os linux --quiet
+ file /Users/rgee0/.arkade/bin/temporal
/Users/rgee0/.arkade/bin/temporal: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), statically linked, Go BuildID=7dvE1Za_dEfKYL5m_CS0/ZCf8zps0OJPGOFkOq9PS/aOSQBWGDAON_9qY26Qyg/Jx20ii24WfAFB0LqH2I1, stripped
+ rm /Users/rgee0/.arkade/bin/temporal
+ echo

+ ./arkade get temporal --arch x86_64 --os mingw --quiet
+ file /Users/rgee0/.arkade/bin/temporal.exe
/Users/rgee0/.arkade/bin/temporal.exe: PE32+ executable (console) x86-64, for MS Windows
+ rm /Users/rgee0/.arkade/bin/temporal.exe
+ echo

make e2e

  arkade git:(updatetctl) ✗ make e2e 
  CGO_ENABLED=0 go test github.com/alexellis/arkade/pkg/get -cover --tags e2e -v
  ...
  PASS
coverage: 61.9% of statements
ok  	github.com/alexellis/arkade/pkg/get	12.021s	coverage: 61.9% of statements

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Maintenance

Documentation

  • I have updated the list of tools in README.md if (required) with ./arkade get --format markdown
  • I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have tested this on arm, or have added code to prevent deployment

Signed-off-by: Richard Gee <[email protected]>
@alexellis alexellis merged commit 6551b09 into alexellis:master Mar 1, 2025
2 checks passed
@alexellis
Copy link
Owner

Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants