Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix flyctl release name" #1106

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

nitishkumar71
Copy link
Contributor

@nitishkumar71 nitishkumar71 commented Jul 17, 2024

Reverts #1097

flyctl has again reverted to old style of release names.

@derek derek bot added the no-dco label Jul 17, 2024
Copy link

derek bot commented Jul 17, 2024

Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project.

Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken.

💡 Shall we fix this?

This will only take a few moments.

First, clone your fork and checkout this branch using the git CLI.

Next, set up your real name and email address:

git config --global user.name "Your Full Name"
git config --global user.email "[email protected]"

Finally, run one of these commands to add the "Signed-off-by" line to your commits.

If you only have one commit so far then run: git commit --amend --signoff and then git push --force.
If you have multiple commits, watch this video.

Check that the message has been added properly by running "git log".

This reverts commit 9cb7222.

Signed-off-by: Nitishkumar Singh <[email protected]>
@nitishkumar71 nitishkumar71 force-pushed the revert-1097-flyctl_fix branch from 5386e4c to f14a7b1 Compare July 17, 2024 09:29
@derek derek bot removed the no-dco label Jul 17, 2024
Copy link
Owner

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Nitish.

@alexellis alexellis merged commit 21509c3 into alexellis:master Jul 19, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants