chore: remove old rollup_bundle

BREAKING CHANGE: internal/rollup_bundle rule is removed. see https://github.com/bazelbuild/rules_nodejs/wiki for migration instructions Fixes bazel-contrib#740
alexeagle · Nov 15, 2019 · 6385baf · 6385baf
1 parent 9fa4343
commit 6385baf
Show file tree

Hide file tree

Showing 21 changed files with 105 additions and 3,348 deletions.
diff --git a/BUILD.bazel b/BUILD.bazel
@@ -50,14 +50,12 @@ bzl_library(
         "//internal/linker:bzl",
         "//internal/npm_package:bzl",
         "//internal/providers:bzl",
-        "//internal/rollup:bzl",
         "//toolchains/node:bzl",
     ],
 )
 
 # Empty node_modules filegroup used for the default
 # value of the node_modules attribute in nodejs_binary
-# and rollup_bundle
 filegroup(
     name = "node_modules_none",
     srcs = [],
@@ -77,10 +75,23 @@ npm_package(
     replace_with_version = "",
     replacements = COMMON_REPLACEMENTS,
     deps = [
+        "//internal:package_contents",
+        "//internal/bazel_integration_test:package_contents",
+        "//internal/common:package_contents",
+        "//internal/copy_repository:package_contents",
+        "//internal/golden_file_test:package_contents",
+        "//internal/jasmine_node_test:package_contents",
+        "//internal/js_library:package_contents",
+        "//internal/linker:package_contents",
+        "//internal/node:package_contents",
+        "//internal/npm_install:package_contents",
+        "//internal/npm_package:package_contents",
+        "//internal/providers:package_contents",
+        "//internal/web_package:package_contents",
         "//third_party/github.com/bazelbuild/bazel-skylib:package_contents",
         "//third_party/github.com/buffer-from:package_contents",
-        "//third_party/github.com/inikulin/parse5:package_contents",
         "//third_party/github.com/gjtorikian/isBinaryFile:package_contents",
+        "//third_party/github.com/inikulin/parse5:package_contents",
         "//third_party/github.com/juanjoDiaz/removeNPMAbsolutePaths:package_contents",
         "//third_party/github.com/source-map:package_contents",
         "//third_party/github.com/source-map-support:package_contents",
@@ -91,21 +102,6 @@ npm_package(
         "//third_party/npm/node_modules/browserify:package_contents",
         "//third_party/npm/node_modules/ieee754:package_contents",
         "//third_party/npm/node_modules/named-amd:package_contents",
-        "//internal:package_contents",
-        "//internal/bazel_integration_test:package_contents",
-        "//internal/golden_file_test:package_contents",
-        "//internal/common:package_contents",
-        "//internal/copy_repository:package_contents",
-        "//internal/jasmine_node_test:package_contents",
-        "//internal/js_library:package_contents",
-        "//internal/linker:package_contents",
-        # TODO(alexeagle): distribute separately as @bazel/rollup
-        "//internal/rollup:package_contents",
-        "//internal/node:package_contents",
-        "//internal/npm_install:package_contents",
-        "//internal/npm_package:package_contents",
-        "//internal/web_package:package_contents",
-        "//internal/providers:package_contents",
         "//toolchains/node:package_contents",
     ],
 )

diff --git a/defs.bzl b/defs.bzl
@@ -29,15 +29,13 @@ load("//internal/node:node_repositories.bzl", _node_repositories = "node_reposit
 load("//internal/node:npm_package_bin.bzl", _npm_bin = "npm_package_bin")
 load("//internal/npm_install:npm_install.bzl", _npm_install = "npm_install", _yarn_install = "yarn_install")
 load("//internal/npm_package:npm_package.bzl", _npm_package = "npm_package")
-load("//internal/rollup:rollup_bundle.bzl", _rollup_bundle = "rollup_bundle")
 load(":index.bzl", "VERSION")
 
 check_bazel_version = _check_bazel_version
 nodejs_binary = _nodejs_binary
 nodejs_test = _nodejs_test
 node_repositories = _node_repositories
 jasmine_node_test = _jasmine_node_test
-rollup_bundle = _rollup_bundle
 npm_package = _npm_package
 npm_package_bin = _npm_bin
 # ANY RULES ADDED HERE SHOULD BE DOCUMENTED, see index.for_docs.bzl

diff --git a/examples/angular/package.json b/examples/angular/package.json
@@ -8,15 +8,15 @@
         "yarn": ">=1.9.2 <2.0.0"
     },
     "dependencies": {
-        "@angular/animations": "9.0.0-next.11",
+        "@angular/animations": "9.0.0-rc.2",
         "@angular/cdk": "8.2.3",
-        "@angular/common": "9.0.0-next.11",
-        "@angular/core": "9.0.0-next.11",
-        "@angular/forms": "9.0.0-next.11",
+        "@angular/common": "9.0.0-rc.2",
+        "@angular/core": "9.0.0-rc.2",
+        "@angular/forms": "9.0.0-rc.2",
         "@angular/material": "8.2.3",
-        "@angular/platform-browser": "9.0.0-next.11",
-        "@angular/platform-browser-dynamic": "9.0.0-next.11",
-        "@angular/router": "9.0.0-next.11",
+        "@angular/platform-browser": "9.0.0-rc.2",
+        "@angular/platform-browser-dynamic": "9.0.0-rc.2",
+        "@angular/router": "9.0.0-rc.2",
         "@ngrx/store": "8.3.0",
         "date-fns": "1.30.1",
         "rxjs": "6.5.3",
@@ -25,10 +25,10 @@
         "zone.js": "0.10.2"
     },
     "devDependencies": {
-        "@angular/bazel": "9.0.0-next.11",
+        "@angular/bazel": "9.0.0-rc.2",
         "@angular/cli": "9.0.0-next.10",
-        "@angular/compiler": "9.0.0-next.11",
-        "@angular/compiler-cli": "9.0.0-next.11",
+        "@angular/compiler": "9.0.0-rc.2",
+        "@angular/compiler-cli": "9.0.0-rc.2",
         "@babel/cli": "^7.6.0",
         "@babel/core": "^7.6.0",
         "@babel/preset-env": "^7.6.0",