-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Relative links #419
Merged
Merged
Fix: Relative links #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feed discovery with relative URLs in links Example: https://k47.cz/ Solution to the problem: alexdebril#417
We will replace the links (add the host if it doesn’t exist) in the content as well
Remember the URL for further processing
Update Node.php (Fix relative URLs in links)
Update Feed.php (Fix relative URLs in links)
Update Reader.php (Fix relative URLs in links)
Update Link.php (Fix relative URLs in links)
If there is approval, then these changes must be made to 5.3.x, which is used in Nextcloud news |
Delete tabs
alexdebril
approved these changes
Oct 16, 2023
Thank you very much @IgorA100 I appreciate the effort. CI is ongoing, I'll merge the PR once it's over |
Thank you! |
yes sure, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example: https://k47.cz/
Solution to the problem: #417
Solution to the problem: #418