Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Relative links #419

Merged
merged 12 commits into from
Oct 16, 2023
Merged

Fix: Relative links #419

merged 12 commits into from
Oct 16, 2023

Conversation

IgorA100
Copy link
Contributor

@IgorA100 IgorA100 commented Oct 14, 2023

  1. Fix: feed discovery with relative URLs in links
  2. Fix: relative links in the Title and in Body

Example: https://k47.cz/
Solution to the problem: #417
Solution to the problem: #418

Feed discovery with relative URLs in links
Example: https://k47.cz/
Solution to the problem: alexdebril#417
We will replace the links (add the host if it doesn’t exist) in the content as well
Remember the URL for further processing
Update Node.php (Fix relative URLs in links)
Update Feed.php (Fix relative URLs in links)
Update Reader.php (Fix relative URLs in links)
Update Link.php (Fix relative URLs in links)
@IgorA100 IgorA100 marked this pull request as ready for review October 14, 2023 22:22
@IgorA100 IgorA100 requested a review from alexdebril as a code owner October 14, 2023 22:22
@IgorA100 IgorA100 marked this pull request as draft October 15, 2023 22:08
@IgorA100
Copy link
Contributor Author

If there is approval, then these changes must be made to 5.3.x, which is used in Nextcloud news
I can do it myself.

Delete tabs
@alexdebril
Copy link
Owner

Thank you very much @IgorA100 I appreciate the effort. CI is ongoing, I'll merge the PR once it's over

@IgorA100
Copy link
Contributor Author

I'll merge the PR once it's over

Thank you!
Can I prepare PR in 5.3.x?

@alexdebril
Copy link
Owner

I'll merge the PR once it's over

Thank you! Can I prepare PR in 5.3.x?

yes sure, thanks a lot!

@alexdebril alexdebril merged commit 0bde9ae into alexdebril:main Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants