Use Option<NonNull<T>> instead of *const () to allow unsized thread locals #27

HyeonuPark · 2023-07-19T14:53:11Z

This change allows to put !Sized types like dyn Trait or [T] on scoped_thread_local!().

As a consequence it adds T: 'static bound which may considered as a breaking change. But it's not possible to construct non-'static thread local with current scope_thread_local!() interface so I believe it can't break any existing code.

Tested on Rust 1.59

…ocals

Use Option<NonNull<T>> instead of *const () to allow unsized thread l…

fcb00f2

…ocals

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use Option<NonNull<T>> instead of *const () to allow unsized thread locals #27

Use Option<NonNull<T>> instead of *const () to allow unsized thread locals #27

HyeonuPark commented Jul 19, 2023

Use Option<NonNull<T>> instead of *const () to allow unsized thread locals #27

Are you sure you want to change the base?

Use Option<NonNull<T>> instead of *const () to allow unsized thread locals #27

Conversation

HyeonuPark commented Jul 19, 2023