Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SFall Misc->MainMenu*OffsetX/Y #41

Merged
merged 2 commits into from
Jun 18, 2022

Conversation

wipe2238
Copy link
Contributor

https://github.com/sfall-team/sfall/blob/6b97ad4bcf6a2c57488a78d30e15a2e87074e50c/sfall/Modules/MainMenu.cpp#L76-L97
https://github.com/sfall-team/sfall/blob/6b97ad4bcf6a2c57488a78d30e15a2e87074e50c/sfall/Modules/MainMenu.cpp#L42-L57
https://github.com/sfall-team/sfall/blob/6b97ad4bcf6a2c57488a78d30e15a2e87074e50c/artifacts/ddraw.ini#L580-L584

Note that it requires modders to go back to "classic" way of changing menu position, by moving buttons backgrounds directly in mainmenu.frm.

That's a bit different from "modern" solution, where HRP provides main menu graphic and buttons background as separate .frms packed into f2_res.dat, and adds them dynamically basing on button position and own offset setting. At least that's how i understood whole thing works. I skipped whole HRP part for now to avoid adding .dat as dependency; menu offsets are not important enough to justify that at this point imho.


Idea for future: once CE gets its own config, all of offset settings could be packed into one option. Instead of multiple settings...

MainMenuOffsetX=392
MainMenuOffsetY=26
;MainMenuCreditsOffsetX=0
;MainMenuCreditsOffsetY=0

...it could be just one with multiple values...

MainMenuOffsets=392 26 0 0 0 0

...which would handle copyright (1st and 2nd value), version (3rd and 4th, not present in current SFall), and menu (5th and 6th).

@wipe2238 wipe2238 mentioned this pull request Jun 10, 2022
52 tasks
@alexbatalov alexbatalov merged commit 5bd0e3c into alexbatalov:main Jun 18, 2022
@wipe2238 wipe2238 deleted the sfall-menuoffset branch June 18, 2022 10:39
ololoken pushed a commit to ololoken/fallout2-ce that referenced this pull request Mar 5, 2025
…changes-from-alex-3

Pick the rest from alex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants