Enable locals completion for defmethod form #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vemv
reviewed
Apr 29, 2022
| (strip-tags (src/candidates "" *ns* (ctx/parse-context | ||
| '(defmethod multimethod "dispatch-val" | ||
| [foo bar & rest] __prefix__)))) | ||
| => (just ["multimethod" "foo" "bar" "rest"])) |
There was a problem hiding this comment.
Suggestion: additionally have a defmethod another-multimethod, and assert that the completions don't get conflated
There was a problem hiding this comment.
Thank you for the suggestion. I think it makes more sense to add another dispatch value instead of another multimethod, though I cannot figure out how to do that with current parse-context implementation. Could you please provide an example?
There was a problem hiding this comment.
Could you please provide an example?
I might PR that at some point, let's merge this one in 👍
|
@rrudakov I'm fine with the proposed improvement. Can you also mention it in the changelog? |
|
@bbatsov done! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.