fix: correctly return error instead of option

Also simplified parsing includes, and removed one yaml lib.

Cargo.toml

@@ -21,7 +21,6 @@ serde = "1.0.197"
 git2 = "0.18.3"
 tree-sitter = "0.20.10"
 tree-sitter-yaml = "0.0.1"
-yaml-rust = "0.4.5"
 reqwest = { version = "0.12.2", features = ["blocking"] }
 regex = "1.10.4"
 serde_yaml = "0.9.34"

src/gitlab_ci_ls_parser/git.rs

@@ -17,7 +17,7 @@ pub trait Git {
         &self,
         remote_pkg: &str,
         remote_tag: &str,
-        remote_files: &[String],
+        remote_files: Vec<String>,
     ) -> anyhow::Result<Vec<GitlabFile>>;
     fn fetch_remote(&self, url: Url) -> anyhow::Result<GitlabFile>;
 }
@@ -108,7 +108,7 @@ impl Git for GitImpl {
         &self,
         remote_pkg: &str,
         remote_tag: &str,
-        remote_files: &[String],
+        remote_files: Vec<String>,
     ) -> anyhow::Result<Vec<GitlabFile>> {
         if remote_tag.is_empty() || remote_pkg.is_empty() || remote_files.is_empty() {
             return Ok(vec![]);

src/gitlab_ci_ls_parser/handlers.rs

@@ -76,15 +76,18 @@ impl LSPHandlers {
                 for (document_uri, node) in nodes.iter() {
                     for (key, content) in node {
                         if key.eq(word) {
-                            let cnt = self.parser.get_full_definition(
+                            let cnt = match self.parser.get_full_definition(
                                 GitlabElement {
                                     key: key.clone(),
                                     content: Some(content.to_string()),
                                     uri: document_uri.to_string(),
                                     ..Default::default()
                                 },
                                 &store,
-                            )?;
+                            ) {
+                                Ok(c) => c,
+                                Err(err) => return Some(LSPResult::Error(err)),
+                            };
 
                             return Some(LSPResult::Hover(HoverResult {
                                 id: request.id,

src/gitlab_ci_ls_parser/messages.rs

@@ -104,14 +104,22 @@ fn handle_result(msg: &Message, result: Option<LSPResult>) -> Option<Message> {
             info!("send definition msg: {:?}", diagnostics_result);
             Some(diagnostics(diagnostics_result))
         }
-        None => match msg {
-            Message::Request(req) => Some(Message::Response(Response {
-                id: req.clone().id,
-                result: Some(serde_json::Value::Null),
-                error: None,
-            })),
-            _ => None,
-        },
+        Some(LSPResult::Error(err)) => {
+            error!("error handling message: {:?} got error: {:?}", msg, err);
+            null_response(msg)
+        }
+        None => null_response(msg),
+    }
+}
+
+fn null_response(msg: &Message) -> Option<Message> {
+    match msg {
+        Message::Request(req) => Some(Message::Response(Response {
+            id: req.clone().id,
+            result: Some(serde_json::Value::Null),
+            error: None,
+        })),
+        _ => None,
     }
 }
 

src/gitlab_ci_ls_parser/mod.rs

@@ -73,6 +73,7 @@ pub enum LSPResult {
     Definition(DefinitionResult),
     Diagnostics(DiagnosticsResult),
     References(ReferencesResult),
+    Error(anyhow::Error),
 }
 
 #[derive(Debug, Clone)]