New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(middleware): add response extractor. #816

Merged

andysim3d merged 9 commits into feat/v0.4 from andy/repsonse-extractor

Oct 8, 2024

Collaborator

andysim3d commented Sep 26, 2024 •

edited

Loading

[Closes/Fixes] #812

Proposed Changes

impl a reponse code extractor. choose to use string to represent the response code because the value range various from HTTP(u16) to grpc(i32) to provider(i64). worries there will be wider range in the future so choose string here.

andysim3d requested review from dancoombs, dphilipson, 0xfourzerofour and alex-miao as code owners

September 26, 2024 19:48

andysim3d force-pushed the andy/repsonse-extractor branch 3 times, most recently from ba6d2d0 to ba1f0c6 Compare

September 26, 2024 20:00

dancoombs reviewed

View reviewed changes

crates/types/src/task/traits.rs Outdated Show resolved Hide resolved

dancoombs reviewed

View reviewed changes

crates/types/src/task/traits.rs Outdated Show resolved Hide resolved

andysim3d force-pushed the andy/repsonse-extractor branch 6 times, most recently from 2d289da to 8306857 Compare

October 2, 2024 19:39

andysim3d requested a review from dancoombs

October 2, 2024 20:25

dancoombs reviewed

View reviewed changes

crates/provider/Cargo.toml Outdated Show resolved Hide resolved

dancoombs reviewed

View reviewed changes

crates/provider/Cargo.toml Outdated Show resolved Hide resolved

dancoombs reviewed

View reviewed changes

crates/provider/src/alloy/metrics.rs Outdated Show resolved Hide resolved

dancoombs reviewed

View reviewed changes

crates/provider/src/alloy/metrics.rs Outdated Show resolved Hide resolved

dancoombs reviewed

View reviewed changes

crates/provider/src/alloy/metrics.rs Outdated Show resolved Hide resolved

dancoombs reviewed

View reviewed changes

crates/provider/src/alloy/metrics.rs Outdated Show resolved Hide resolved

dancoombs reviewed

View reviewed changes

crates/provider/src/alloy/metrics.rs Outdated Show resolved Hide resolved

dancoombs reviewed

View reviewed changes

crates/provider/src/alloy/metrics.rs Outdated Show resolved Hide resolved

dancoombs reviewed

View reviewed changes

crates/provider/src/alloy/metrics.rs Outdated Show resolved Hide resolved

dancoombs reviewed

View reviewed changes

crates/rpc/src/rpc_metrics.rs Show resolved Hide resolved

dancoombs reviewed

View reviewed changes

crates/task/src/grpc/grpc_metrics.rs Show resolved Hide resolved

dancoombs reviewed

View reviewed changes

crates/types/src/task/metric_recorder.rs Show resolved Hide resolved

dancoombs reviewed

View reviewed changes

crates/types/src/task/metric_recorder.rs Outdated Show resolved Hide resolved

andysim3d force-pushed the andy/repsonse-extractor branch from 8306857 to 969bfbc Compare

October 4, 2024 21:16

dancoombs reviewed

View reviewed changes

crates/rpc/src/rpc_metrics.rs Outdated Show resolved Hide resolved

dancoombs reviewed

View reviewed changes

crates/task/src/grpc/grpc_metrics.rs Outdated Show resolved Hide resolved

dancoombs reviewed

View reviewed changes

crates/types/src/task/metric_recorder.rs Show resolved Hide resolved

andysim3d force-pushed the andy/repsonse-extractor branch 2 times, most recently from ae9b9d7 to 8cb8bd5 Compare

October 7, 2024 19:45

andysim3d requested review from dancoombs and 0xfourzerofour

October 7, 2024 20:55

andysim3d added 7 commits

October 7, 2024 16:55


          feat(middleware): add response extractor.

ed8c6da


          feat(middleware): add response extractor


          feat(middleware): reworking middleware.

8a6cb10


          fix: meger with master.

de50fc4


          feat(middleware): make middleware compile.

4f2cbf5


          feat(middleware): rework middleware, split rpc and http.

b2fd241


          feat(middleware): use jsonrpc-method as the makeup http method name. …

adbc345

…And only log http status for jsonrpc.

andysim3d force-pushed the andy/repsonse-extractor branch from 8cb8bd5 to b762d96 Compare

October 7, 2024 20:55

dancoombs reviewed

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

dancoombs reviewed

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved


          feat(middleware): code cleanning.

andysim3d force-pushed the andy/repsonse-extractor branch from b762d96 to 3598104 Compare

October 8, 2024 13:55

dancoombs reviewed

View reviewed changes

bin/rundler/Cargo.toml Outdated Show resolved Hide resolved

andysim3d requested a review from dancoombs

October 8, 2024 17:33

andysim3d force-pushed the andy/repsonse-extractor branch from 30cd840 to 1aaa9ee Compare

October 8, 2024 17:35

dancoombs reviewed

View reviewed changes

crates/types/Cargo.toml Outdated

               mockall = {workspace = true, optional = true }
               [dev-dependencies]
               rundler-types = { workspace = true, features = ["test-utils"] }
               alloy-primitives = { workspace = true, features = ["rand"] }
+              cargo-husky = { version = "1", default-features = false, features = ["user-hooks"] }

Collaborator

dancoombs Oct 8, 2024

Can't this be cargo-husky.workspace = true


          fix: add cargo-husky back.

4e8cc01

andysim3d force-pushed the andy/repsonse-extractor branch from 1aaa9ee to 4e8cc01 Compare

October 8, 2024 18:47

dancoombs approved these changes

View reviewed changes

andysim3d merged commit 81d88be into feat/v0.4

8 checks passed

andysim3d deleted the andy/repsonse-extractor branch

October 8, 2024 19:03

dancoombs pushed a commit that referenced this pull request


          feat(middleware): add response extractor. (#816)

885cc9c

dancoombs pushed a commit that referenced this pull request


          feat(middleware): add response extractor. (#816)

88b1542

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dancoombs dancoombs approved these changes

dphilipson Awaiting requested review from dphilipson dphilipson is a code owner

alex-miao Awaiting requested review from alex-miao alex-miao is a code owner

0xfourzerofour Awaiting requested review from 0xfourzerofour 0xfourzerofour is a code owner

Labels

None yet