Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial progress and cancelation support #70

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Conversation

albertziegenhagel
Copy link
Owner

@albertziegenhagel albertziegenhagel commented Oct 13, 2024

Adds initial support for progress reporting and cancellation to all file processing and analysis algorithms.
Does not yet add support to the protocol and server.

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 90.78947% with 7 lines in your changes missing coverage. Please review.

Project coverage is 83.38%. Comparing base (18760e6) to head (f5a9573).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
snail/analysis/diagsession_data_provider.cpp 82.35% 2 Missing and 1 partial ⚠️
snail/etl/etl_file.cpp 75.00% 0 Missing and 2 partials ⚠️
snail/analysis/analysis.cpp 92.85% 0 Missing and 1 partial ⚠️
snail/perf_data/perf_data_file.cpp 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
+ Coverage   83.11%   83.38%   +0.26%     
==========================================
  Files         103      104       +1     
  Lines        4631     4700      +69     
  Branches      899      917      +18     
==========================================
+ Hits         3849     3919      +70     
- Misses        379      380       +1     
+ Partials      403      401       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albertziegenhagel albertziegenhagel marked this pull request as ready for review October 14, 2024 18:26
@albertziegenhagel albertziegenhagel force-pushed the progress-support branch 2 times, most recently from cc1e2a5 to d946206 Compare October 14, 2024 19:01
@albertziegenhagel albertziegenhagel merged commit 1307357 into main Oct 14, 2024
5 checks passed
@albertziegenhagel albertziegenhagel deleted the progress-support branch October 14, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant