Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure assets are downloaded just once #18

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Ensure assets are downloaded just once #18

merged 1 commit into from
Nov 4, 2020

Conversation

petrsvihlik
Copy link
Contributor

Avoids the "Multiple documents… output to" error.

Motivation

OCD (and also performance)

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable) N/A
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

  • create two or more pipelines with KontentImageProcessor whose output will contain assets () with the same URLs
  • create another pipeline based on the KontentDownloadImages
  • run dotnet run -- preview and make sure that:
    • there are no errors in the log such as Multiple documents output to img/1.jpg (this probably wasn't intended)
    • all assets are downloaded correctly

@petrsvihlik
Copy link
Contributor Author

@alanta please let me know if the PR's up to your expectations :)

I might have a few more coming

@alanta alanta merged commit a518389 into alanta:main Nov 4, 2020
@alanta
Copy link
Owner

alanta commented Nov 4, 2020

Looks like a clean fix, thanks!

@petrsvihlik petrsvihlik deleted the feature/distinct-local-paths branch November 4, 2020 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants