asyncio for make-stats #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iain-S
reviewed
Jun 10, 2023
| @@ -167,7 +168,9 @@ def make_stats( | |||
| typer.echo("Missing source database connection details.", err=True) | |||
| sys.exit(1) | |||
|
|
|||
| src_stats = make_src_stats(src_dsn, config) | |||
| src_stats = asyncio.get_event_loop().run_until_complete( | |||
There was a problem hiding this comment.
If this change was purely for SSG then it sounds like .run() would be simplest but I guess we're calling make_stats from TAPAS so there might already be a loop running?
Suggested change
| src_stats = asyncio.get_event_loop().run_until_complete( | |
| src_stats = asyncio.get_event_loop().run_until_complete( |
There was a problem hiding this comment.
Yeaaah, I think that was my logic here. I'm not super sure of my understanding of how things like multiple event loops work though.
Async make stats iain
Co-authored-by: Iain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs the make-stats queries in parallel.