Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install sqlacodegen from PyPI so that we can publish to PyPI #94

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

Iain-S
Copy link
Collaborator

@Iain-S Iain-S commented Jun 1, 2023

PyPI packages cannot have git+ dependencies.

@Iain-S Iain-S added the WIP Work in Progress (do not merge) label Jun 1, 2023
@Iain-S Iain-S requested a review from cptanalatriste June 1, 2023 09:03
@Iain-S
Copy link
Collaborator Author

Iain-S commented Jun 1, 2023

@cptanalatriste we had intended to discuss PyPI release plans & git branching yesterday but didn't get a chance. Probably worth settling that before merging this?

@Iain-S
Copy link
Collaborator Author

Iain-S commented Jun 1, 2023

See also #9

Copy link
Collaborator

@cptanalatriste cptanalatriste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Iain-S Iain-S removed the WIP Work in Progress (do not merge) label Jun 1, 2023
@Iain-S Iain-S merged commit 65962e9 into main Jun 1, 2023
@Iain-S Iain-S deleted the sqlacodegen-dependency branch June 1, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants