YAML vocab files #70
Merged
YAML vocab files #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just noticed JSON can't deal with datetimes. Turning this back into a draft until that's fixed. |
|
Switched from JSON to YAML to handle datetimes and other general python objects. |
Iain-S
approved these changes
Apr 17, 2023
|
I added a timestamp column to concepts to check that the yaml files can handle date times in vocab files. |
Co-authored-by: Iain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to using
JSONYAML as the file format for vocabulary table dumps. This circumvents the issue where CSV fails to distinguish between null and empty string.The PR also adds more data into the
src.dumpthat cause tests to fail when using CSV files (by having some NULL values in an integer column). While I was at it, I also added something that should cause tests to fail before #68 is merged (vocabulary tables with non-trivial FK constraints amongst each other).Builds on #69, the diff is going to be nicer once that is merged.
Closes #65