-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to specify the destination schema name #64
Conversation
I'm not sure what will happen if the src schema is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I only have a few style questions/points. Also, happy with how make_tables
now avoids calling run
(at the cost of some importlib
stuff, but no free lunch).
I wouldn't mind it if it used |
I tried running with and without |
We manually set the schema name in for the whole connection session using an explicit
SET SEARCH_PATH TO
statement.This allows the user to have a different destination schema name than the source schema.
The disadvantage is that we cannot support multiple source schemas (not that we did previously, but this makes it harder), though postgres does allow you to set more than one schema on a search path with
SET SEARCH_PATH TO schema1, schema2;
.Would appreciate some testing on a real database.