Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

46 tables without pks #47

Merged
merged 3 commits into from
Feb 27, 2023
Merged

46 tables without pks #47

merged 3 commits into from
Feb 27, 2023

Conversation

Iain-S
Copy link
Collaborator

@Iain-S Iain-S commented Feb 27, 2023

  1. Add a table without a PK to the test database via src.dump file
  2. Add note to docs about tables without PKs

As far as I can tell, the basic functionality of SSG does work when a tables doesn't have a PK. However, vocabularies don't work (a relatively easy naming fix if we wanted).

@Iain-S Iain-S requested review from myyong and mhauru February 27, 2023 16:19
@Iain-S
Copy link
Collaborator Author

Iain-S commented Feb 27, 2023

Closes #46

@Iain-S Iain-S force-pushed the 46-tables-without-pks branch from 4206f06 to 47ecd2a Compare February 27, 2023 16:36
@Iain-S Iain-S merged commit 5d0699e into main Feb 27, 2023
@Iain-S Iain-S deleted the 46-tables-without-pks branch February 27, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants