Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

42 num rows per pass #45

Merged
merged 3 commits into from
Feb 24, 2023
Merged

42 num rows per pass #45

merged 3 commits into from
Feb 24, 2023

Conversation

Iain-S
Copy link
Collaborator

@Iain-S Iain-S commented Feb 24, 2023

Closes #42

  • Converts the num_rows_per_pass: 2 entry in the config .yaml into a num_rows_per_pass = 2 member variable in the generator class when we do make-generators ....
  • Runs the generator that many times when we do create-data ....

@Iain-S Iain-S requested a review from mhauru February 24, 2023 17:33
mhauru
mhauru approved these changes Feb 24, 2023
View reviewed changes
Copy link
Collaborator

@mhauru mhauru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Iain-S Iain-S merged commit 6b6b10c into main Feb 24, 2023
@Iain-S Iain-S deleted the 42-num-rows-per-pass branch February 24, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhauru mhauru mhauru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make num_rows_per_pass work
2 participants
@Iain-S @mhauru