Pass src_conn and dst_conn to generators when we create-data #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iain-S
force-pushed
the
marginals
branch
4 times, most recently
from
99b4d82 to
836c101
Compare
Iain-S
changed the title
mhauru
approved these changes
Jan 20, 2023
In addition to the destination connection they already have
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Begins work on #24
We pass in the src and dst database connections as we construct SSG Generator objects so that the user can either
Note that there is no DP or noise at this point.
We also rename the foreign key provider because it is more general than the name suggests.