Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to null_provider for unrecognised column types, with warning #161

Merged
merged 4 commits into from
Nov 15, 2023
Merged

Default to null_provider for unrecognised column types, with warning #161

merged 4 commits into from
Nov 15, 2023

Conversation

mhauru
Copy link
Collaborator

@mhauru mhauru commented Oct 25, 2023 •
edited
Loading

Closes #154

@mhauru mhauru requested a review from Iain-S October 25, 2023 14:27
Iain-S
Iain-S approved these changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@Iain-S Iain-S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Iain-S Iain-S merged commit 43ee420 into main Nov 15, 2023
@Iain-S Iain-S deleted the unrecognised-column-types branch November 15, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Iain-S Iain-S Iain-S approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle unrecognised column types without erroring
2 participants
@mhauru @Iain-S