Sqla2 type hints iain #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iain-S
force-pushed
the
sqla2-type-hints-iain
branch
from
3aacd0e to
8eebb1c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
MagicMock(spec=MockedClass)feature to remove# type: ignorefrom tests. See https://stackoverflow.com/a/11283173/3324095Sequencein place ofListandMappingin place ofDictin function parameters as this allows a wider range of types to be passed in. Keeps concrete types for return types as they are more precise.ListforlistandDictfordictas we require Python >= 3.9 and this feature was added in 3.9.