Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

column defaults #140

Merged
merged 4 commits into from
Sep 6, 2023
Merged

column defaults #140

merged 4 commits into from
Sep 6, 2023

Conversation

Iain-S
Copy link
Collaborator

@Iain-S Iain-S commented Sep 6, 2023

The current code handles defaults if they come from a PK but not if they come from server-side column defaults.

@Iain-S Iain-S requested a review from mhauru September 6, 2023 09:25
@Iain-S Iain-S mentioned this pull request Sep 6, 2023
@mhauru
Copy link
Collaborator

mhauru commented Sep 6, 2023

This is a really good catch. The new code looks good, there just seems to be a simple failure in one of the old tests.

@Iain-S
Copy link
Collaborator Author

Iain-S commented Sep 6, 2023

Added poetry.lock to the pre-commit workflow cache key as a change to, e.g., the version of isort we use should trigger a rebuild.

@mhauru mhauru merged commit b5fdcc8 into sqlalchemy2 Sep 6, 2023
@Iain-S Iain-S deleted the sqlalchemy2-iain branch September 11, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants