Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug where we couldn't handle returned_defaults=None #105

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Fix bug where we couldn't handle returned_defaults=None #105

merged 1 commit into from
Jun 22, 2023

Conversation

mhauru
Copy link
Collaborator

@mhauru mhauru commented Jun 21, 2023

Closes #99

@mhauru mhauru requested a review from Iain-S June 21, 2023 16:35
Iain-S
Iain-S approved these changes Jun 21, 2023
View reviewed changes
Copy link
Collaborator

@Iain-S Iain-S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhauru mhauru merged commit c7540c8 into main Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Iain-S Iain-S Iain-S approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

story generators errors if returned_defaults is None
2 participants
@mhauru @Iain-S